FS#48684 - [virt-manager] installation of virt-manager from virt-install to /ust/bin without execution rights

Attached to Project: Community Packages
Opened by Levente Polyak (anthraxx) - Thursday, 24 March 2016, 10:41 GMT
Last edited by Sergej Pupykin (sergej) - Thursday, 24 March 2016, 12:23 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Installing files to /usr/bin and forcefully removing execution permissions just because its supposed to only work when virt-manager is installed and chmod +x in its .install script is an absolute no-go.
This script has to be moved into the virt-manager package.
Additionally there is no good pyo/pyc handling, those should be tracked by pacman and installed through the package, not by python when someone starts it as root.

Find attached a PKGBUILD and .install script that addresses all this issues (also the pkgrel is bumped)
- compiles pyo and pyc files in virt-install
- removes rm -r *.pyc
- moves the virt-manager script to virt-manager package

cheers
Levente
This task depends upon

Closed by  Sergej Pupykin (sergej)
Thursday, 24 March 2016, 12:23 GMT
Reason for closing:  Fixed
Comment by Allan McRae (Allan) - Thursday, 24 March 2016, 11:54 GMT
"Additionally there is no good pyo/pyc handling" -> I'd go further and state no files should end with .py in /usr/bin/

Loading...