FS#48209 - [python2-keybinder2] pulling source from non-static git HEAD (github master tarball)

Attached to Project: Community Packages
Opened by Levente Polyak (anthraxx) - Tuesday, 16 February 2016, 17:37 GMT
Last edited by Balló György (City-busz) - Wednesday, 10 January 2018, 19:00 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Balló György (City-busz)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hi, during some tests I observed that the current PKGBUILD is pulling directly the master tarball from github, this is equivalent to checking out the current git HEAD.
I assume this was just a small accident, however it would be great if this could be fixed and a updated version released.

Just in case, a small explanation:
Packages should always be re-buildable and reproducible, which requires PKGBUILD source option to point to the very same upstream version/source. If it is not possible to reference a release tarball (because there may not be any) then it should be pinned to a static git commit hash.

cheers,
Levente
This task depends upon

Closed by  Balló György (City-busz)
Wednesday, 10 January 2018, 19:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  libkeybinder2 0.3.1-2 and python2-keybinder2 0.3.1-2
Comment by Eli Schwartz (eschwartz) - Tuesday, 14 November 2017, 22:07 GMT
This was originally added in 0.3.0-2 when switching to github for the archive download, but the developers upload the same prebuilt dist archive at https://github.com/kupferlauncher/keybinder/releases/download/v0.3.1/keybinder-0.3.1.tar.gz

Which should let us drop the makedepends that were added for gnome-common and gtk-doc, as well as skipping autogen.sh

Also the keybinder2 code is on the keybinder-legacy branch...

(This also appears to be orphaned now.)

Loading...