FS#48004 - [syncthing] Consider building with GOROOT_FINAL

Attached to Project: Community Packages
Opened by Stefan Tatschner (rumpelsepp) - Wednesday, 03 February 2016, 09:27 GMT
Last edited by Jaroslav Lichtblau (Dragonlord) - Wednesday, 10 February 2016, 09:29 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
Martin Wimpress (flexiondotorg)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

It may be worth looking at the environment variable GOROOT_FINAL [1] when building syncthing (or Go packages in general). This would avoid ugly pathnames in panic logs [2] like this one:

/tmp/makepkg/syncthing-git/src/src/github.com/syncthing/syncthing/cmd/syncthing/usage_report.go:285 +0x597
github.com/thejerf/suture.(*Supervisor).runService.func1(0xc8201cd790, 0x0, 0x7f3cb1323818, 0xc8224f3b00)
/tmp/makepkg/syncthing-git/src/src/github.com/syncthing/syncthing/Godeps/_workspace/src/github.com/thejerf/suture/suture.go:556 +0x5e
created by github.com/thejerf/suture.(*Supervisor).runService
/tmp/makepkg/syncthing-git/src/src/github.com/syncthing/syncthing/Godeps/_workspace/src/github.com/thejerf/suture/suture.go:559 +0x51
goroutine 116 [sleep]:

GOROOT_FINAL="/usr/bin" should be reasonable.

[1]: https://golang.org/cmd/go/#hdr-Environment_variables
[2]: https://github.com/syncthing/syncthing/issues/2342
This task depends upon

Closed by  Jaroslav Lichtblau (Dragonlord)
Wednesday, 10 February 2016, 09:29 GMT
Reason for closing:  Implemented
Additional comments about closing:  Implemented in syncthing-0.12.18-1 placed in [community-testing] as of now
Comment by Doug Newgard (Scimmia) - Wednesday, 03 February 2016, 17:46 GMT
It seems those log entries are from syncthing-git
Comment by Stefan Tatschner (rumpelsepp) - Wednesday, 03 February 2016, 17:48 GMT
It was a custom PKGBUILD, which I made myself. I copied the official PKGBUILD, cloned from git instead and added a pkgver() function. The issue applies to both. :)

Loading...