FS#47971 - [mutter] Backport patch - fixes problem where window switcher and hot-corner stops working

Attached to Project: Arch Linux
Opened by G. Richard Bellamy (rbellamy) - Sunday, 31 January 2016, 19:34 GMT
Last edited by Jan de Groot (JGC) - Monday, 13 June 2016, 22:18 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
From 723a27e280cbe3f4d7975b7f35217b5600bfbe00 Mon Sep 17 00:00:00 2001
From: Sebastian Keller <sebastian-keller@gmx.de>
Date: Sun, 10 Jan 2016 04:15:09 +0100
Subject: [PATCH] xprops: Null-terminate property reply values

Some of the mutter code using these properties expects them to be
null-terminated whereas xcb does not use null-terminated strings:

http://xcb.freedesktop.org/XcbRationale/

This was in some cases resulting in the WM_CLASS property containing
garbage data which broke application matching, caused the hot-corner and
window-switcher to stop working, or was exposed as text in the UI.

https://bugzilla.gnome.org/show_bug.cgi?id=759658

Additional info:
* mutter-3.18.2-1
Jan 31 10:20:13 eanna gnome-session[1871]: (gnome-shell:11444): Gjs-WARNING **: JS ERROR: TypeError: this._switcherList is null
Jan 31 10:20:13 eanna gnome-session[1871]: SwitcherPopup<._allocate@resource:///org/gnome/shell/ui/switcherPopup.js:94
Jan 31 10:20:13 eanna gnome-session[1871]: wrapper@resource:///org/gnome/gjs/modules/lang.js:178
Jan 31 10:20:13 eanna gnome-session[1871]: _parent@resource:///org/gnome/gjs/modules/lang.js:131
Jan 31 10:20:13 eanna gnome-session[1871]: AppSwitcherPopup<._allocate@resource:///org/gnome/shell/ui/altTab.js:72
Jan 31 10:20:13 eanna gnome-session[1871]: wrapper@resource:///org/gnome/gjs/modules/lang.js:178
Jan 31 10:20:13 eanna gnome-session[1871]: LayoutManager<._init/<@resource:///org/gnome/shell/ui/layout.js:204

Steps to reproduce:
1. Install mutter-3.18.2-1
2. Launch an application that has non-null-terminated strings as part of it's xcb output.
The application suggested by a duplicate upstream () is tn5250j-0.7.6-1.
For me it could any one of (not sure which, but I am definitely running into this bug repeatedly):
2a. intelli-idea-ultimate-edition-15.0.3-1
2b. oracle-sqldeveloper-4.1.2.20.64-1
2c. datagrip-1.0.2-1
3. Over time, eventually lose window switcher and hot-corner.
This task depends upon

Closed by  Jan de Groot (JGC)
Monday, 13 June 2016, 22:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  Included in 3.20.x
Comment by G. Richard Bellamy (rbellamy) - Sunday, 31 January 2016, 19:34 GMT
Forgot to add link to upstream duplicate: https://bugzilla.gnome.org/show_bug.cgi?id=757689

Loading...