FS#47888 - [cantata] Build with -DENABLE_LIBVLC=OFF
Attached to Project:
Community Packages
Opened by Federico (nierro) - Monday, 25 January 2016, 11:01 GMT
Last edited by Antonio Rojas (arojas) - Sunday, 24 April 2016, 11:04 GMT
Opened by Federico (nierro) - Monday, 25 January 2016, 11:01 GMT
Last edited by Antonio Rojas (arojas) - Sunday, 24 April 2016, 11:04 GMT
|
Details
Description:
starting with version 2.0 cantata pulls in vlc as dep. Vlc needs qt4, and it seems quite useless depending on it only because cantata can optionally be built with libvlc instead of qt5-multimedia. Even if libvlc builds are default on linux, i tried to build it with -DENABLE_LIBVLC=OFF, and everything seems to be working fine (streams too). So, can we have libvlc-less builds? Additional info: * cantata 2.0 Thanks! |
This task depends upon
Closed by Antonio Rojas (arojas)
Sunday, 24 April 2016, 11:04 GMT
Reason for closing: Won't implement
Sunday, 24 April 2016, 11:04 GMT
Reason for closing: Won't implement
By the way, as cantata is built with qt5-enabled, i don't consider having qt5-multimedia as dep as weighty as pulling in an entire new toolkit.
And surely less "stupid" (i'd like to avoid this word, but it is the only i came up with) than pulling in a media player to build a music player.
These are just my 2 cents, obviously.
Agreed, I've reopened
FS#21934. The VLC maintainer is currently MIA though.From the original git commit: (https://github.com/CDrummond/cantata/issues/493):
"I have created a patch for enabling Cantata to use LibVLC as a streaming
playback backend. Maybe you want to include it.
Why?
- The GStreamer-backend in QMultimedia is linked against GStreamer 0.10, which
has a problem playing http-streams at all (Linux)."
Let's make VLC an optional dependency of cantata, since you can absolutely use it without VLC burden.
FS#21934is implemented properly, I've made the qt4 dependency optional in vlc.Note that upstream made vlc the default for a reason (see https://github.com/CDrummond/cantata/issues/810 ) and I won't override their decision.