FS#47789 - [ffmpeg] Redundant patches

Attached to Project: Arch Linux
Opened by Chih-Hsuan Yen (yan12125) - Saturday, 16 January 2016, 17:06 GMT
Last edited by Maxime Gauduin (Alucryd) - Saturday, 16 January 2016, 19:24 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
ffmpeg 2.8.5 has already included patches for HLS. There's no need to manually patch it in PKGBUILD.

Additional info:
extra/ffmpeg 1:2.8.5-1

Ref:  FS#47738 
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Saturday, 16 January 2016, 19:24 GMT
Reason for closing:  Fixed
Additional comments about closing:  1:2.8.5-2
Comment by Evangelos Foutras (foutrelis) - Saturday, 16 January 2016, 18:02 GMT
Obviously the patches will be dropped when ffmpeg is updated to 2.8.5; that's just normal packaging stuff and not something you need to file a task about.

Also I'm not sure where you got "extra/ffmpeg 1:2.8.5-1"; current version is 1:2.8.4-4.
Comment by Evangelos Foutras (foutrelis) - Saturday, 16 January 2016, 18:06 GMT
Ehm, ignore my previous comment; ffmpeg was indeed bumped to 1:2.8.5-1 in SVN without removing the patches.
Comment by Chih-Hsuan Yen (yan12125) - Saturday, 16 January 2016, 18:09 GMT
https://projects.archlinux.org/svntogit/packages.git/tree/ffmpeg/repos/extra-x86_64/PKGBUILD

Actually I see it on arch-commits mailing list. Due to unknown reasons the binary package is not built and synced yet. I expect later there will be a commit to drop these patches from PKGBUILD, but there's nothing. This is just a ticket to prevent possible problems.
Comment by Maxime Gauduin (Alucryd) - Saturday, 16 January 2016, 19:24 GMT
Patch happily patched the files so I assumed 2.8.5 didn't contain them, then I realized my mistake which is why it was in SVN only. Just pushed 2.8.5-2 without the patches.

Loading...