FS#47714 - [vlc] upgrade to qt5

Attached to Project: Arch Linux
Opened by Amos Onn (amos) - Monday, 11 January 2016, 16:49 GMT
Last edited by Levente Polyak (anthraxx) - Friday, 23 February 2018, 13:26 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 8
Private No

Details

Description:
VLC has moved to support qt5 (in addition to qt4) since version 2.1. I tried to compile vlc using the current makepkg, just replacing the dependency and the RCC binary to qt5, and it worked.
In way of progress, it seems reasonable to move to qt5, or perhaps offer both packages vlc-qt4 and vlc-qt5 as providing vlc. What do you think?
This task depends upon

Closed by  Levente Polyak (anthraxx)
Friday, 23 February 2018, 13:26 GMT
Reason for closing:  Implemented
Additional comments about closing:  3.0.0-1
Comment by John (graysky) - Monday, 11 January 2016, 20:07 GMT
I built vlc making the attached change to the PKGBUILD but found that it fails to run ending in the following error... what am I missing?
% vlc
VLC media player 2.2.1 Terry Pratchett (Weatherwax) (revision 2.2.1-0-ga425c42)
[0000000001398158] core libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
[00000000014d7868] skins2 interface error: no suitable dialogs provider found (hint: compile the qt4 plugin, and make sure it is loaded properly)
[00000000014d7868] skins2 interface error: cannot instantiate qt4 dialogs provider
[00000000014d7868] [cli] lua interface: Listening on host "*console".
VLC media player 2.2.1 Terry Pratchett (Weatherwax)
Command Line Interface initialized. Type `help' for help.
> quit
Shutting down.
[00000000014d7868] [cli] lua interface: Requested shutdown.

Comment by Amos Onn (amos) - Monday, 11 January 2016, 22:08 GMT
I don't know. I just rebuilt, using your patch (sorry for not posting one myself), and I don't get the errors above, just:

% vlc
VLC media player 2.2.1 Terry Pratchett (Weatherwax) (revision 2.2.1-0-ga425c42)
[0000000002608378] pulse audio output error: PulseAudio server connection failure: Connection refused
[00000000024f3238] core libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.

and the player loads normally, plays videos etc. I can send you my build for inspection, or vice versa.

However, I think your error corresponds to custom skins for vlc which break. A google search for skins2 gives this: http://www.videolan.org/vlc/skins.php , which states skins2 as the directory for placing custom skins. Perhaps some of these skins are not qt5 compatible - or perhaps the whole skin system isn't. I would suggest you try changing vlc back to default ui, and then run the package.

If this is indeed the case, then perhaps it is another reason to have both vlc-qt4 and vlc-qt5.
Comment by John (graysky) - Monday, 11 January 2016, 22:13 GMT
I don't have any custom skins at all... perhaps you have a qt4 dep on your system from another package?

pacman -Qs qt4
Comment by Amos Onn (amos) - Monday, 11 January 2016, 23:01 GMT
I do have, but I ran
pacman -Rdd qt4
before trying to run vlc.

Amos.
Comment by Amos Onn (amos) - Saturday, 23 January 2016, 21:38 GMT
Is there a way we can proceed from here? I can send you my binary, or perhaps you can send me yours?
I hope to try building & running this on a fresh arch VM sometime soon.

Amos.
Comment by John (graysky) - Saturday, 23 January 2016, 21:40 GMT
Let's see what Giovanni has to say.
Comment by Amos Onn (amos) - Sunday, 24 January 2016, 22:22 GMT
In the meantime, some missing makedepends:
make, gcc, patch, libssh2, pkgconfig.
Some of them could be written off as obvious, but libssh2, and arguably pkgconfig, are not.

I built and ran vlc inside a clean arch virtualbox, and ran it both via ssh +X from outside and an X server from inside. However, to make sure that no qt4 was inserted, I removed the deps on kdelibs, which brings with it phonon-qt4, which in turn wants phonon-qt4-backend, which is provided either by phonon-qt4-gstreamer or by phonon-qt4-vlc (!).

I also built and ran successfully vlc with phonon-qt4-gstreamer, removing it (and qt4) after build. Using phonon-qt4-vlc is circular, since this package requires vlc, of course.

However, it seems that all this phonon-qt4 things is legacy; there exists phonon-qt5-vlc, depending on vlc as well. All this kdelibs seems like a legacy thing, that can be dropped altogether (or replaced with the plasma5 version).
Comment by Doug Newgard (Scimmia) - Sunday, 24 January 2016, 23:57 GMT
The entire base-devel group is assumed to be installed at build time.
Comment by Amos Onn (amos) - Monday, 25 January 2016, 10:02 GMT
OK, my mistake, also libssh2 is apparently included in the makedepends already.
Comment by Balló György (City-busz) - Friday, 17 February 2017, 17:35 GMT
Now I added a vlc-qt5 package to the AUR:
https://aur.archlinux.org/packages/vlc-qt5/
Comment by trendkiller (trendkiller) - Sunday, 05 March 2017, 18:41 GMT
is the aur package working correctly?
if it is, maybe it's time to upgrade the official package.
Comment by Balló György (City-busz) - Sunday, 05 March 2017, 18:51 GMT
It works, but there is one problem: videos are displayed in an external window rather than within the main VLC window. So the port is unfinished in vlc 2. vlc 3 will have full support for Qt5.
Comment by Amos Onn (amos) - Sunday, 05 March 2017, 20:25 GMT
I repeat my suggestion from before, to have vlc-qt4 and vlc-qt5 which both provide vlc. vlc-qt4 can be dropped when vlc move on to v3.
Comment by Levente Polyak (anthraxx) - Sunday, 05 November 2017, 21:58 GMT
this won't happen until its properly supported. there is no point officially enabling something that is broken and unfinished

Loading...