FS#47556 - [samba] upstream systemd service files not shipped

Attached to Project: Arch Linux
Opened by Zachary Cook (Zeik) - Tuesday, 29 December 2015, 09:06 GMT
Last edited by Tobias Powalowski (tpowa) - Thursday, 15 March 2018, 10:32 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:
The service files provided by upstream should be used, they use Type=notify which should be less error prone than Type=forking

Version: 4.3.3-1
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Thursday, 15 March 2018, 10:32 GMT
Reason for closing:  Fixed
Additional comments about closing:  4.8.0-1
Comment by Marcos Mello (marcosfrm) - Sunday, 10 December 2017, 17:10 GMT
Yes, but let's wait for these commits land in 4.7-stable:

https://git.samba.org/?p=samba.git;a=commit;h=af38d73b06c0c40ef59c2ffe0fc6580b0787b7d0
https://git.samba.org/?p=samba.git;a=commit;h=8736013dc42c5755b75bbb2e843a290bcd545909
https://git.samba.org/?p=samba.git;a=commit;h=8b6f58194da7e849cdb9d20712dff49b17a93a77
Comment by Marcos Mello (marcosfrm) - Thursday, 21 December 2017, 11:11 GMT
One more:

https://git.samba.org/?p=samba.git;a=commit;h=0806ff7dfd3f982226e4cd9b923a0e570b765f0c

All four are now in 4.7-test and probably will be in 4.7.4.
Comment by Marcos Mello (marcosfrm) - Tuesday, 26 December 2017, 09:32 GMT
4.7.4 was released with all above fixes.
Comment by Marcos Mello (marcosfrm) - Wednesday, 07 February 2018, 19:45 GMT
Future 4.8.0 release will make things easier for packagers with the new "--systemd-install-services" configure option (older "--with-systemd" is also needed to build Samba code linking libsystemd).
Comment by Marcos Mello (marcosfrm) - Friday, 09 February 2018, 10:46 GMT
Patch to fix this bug ( FS#47556 ) and  FS#56658 .
   samba.patch (5.7 KiB)
Comment by Marcos Mello (marcosfrm) - Saturday, 10 February 2018, 20:58 GMT
Version 2.

Use /etc/conf.d/samba from upstream.
   samba_v2.patch (6.4 KiB)
Comment by Tobias Powalowski (tpowa) - Wednesday, 14 March 2018, 08:12 GMT
Could you update the patch for 4.8.x?
It is not working with 4.8.0
sed: can't read /build/samba/src/samba-4.8.0/packaging/systemd/*.service: No such file or directory
Comment by Eli Schwartz (eschwartz) - Wednesday, 14 March 2018, 20:56 GMT
The patch indicates that --systemd-install-services should be used.

Attached are modifications that include that, as well as quoting srcdir/pkgdir and moving checksums up with the other PKGBUILD variables/arrays.
(application/x-gzip)    samba-checkpkg.tar.gz (14.5 KiB)
   samba.diff (16.9 KiB)

Loading...