FS#47413 - [postgresql] improved pkg
Attached to Project:
Arch Linux
Opened by Yamakaky (Yamakaky) - Wednesday, 16 December 2015, 21:43 GMT
Last edited by Levente Polyak (anthraxx) - Wednesday, 13 March 2019, 22:47 GMT
Opened by Yamakaky (Yamakaky) - Wednesday, 16 December 2015, 21:43 GMT
Last edited by Levente Polyak (anthraxx) - Wednesday, 13 March 2019, 22:47 GMT
|
Details
Changes:
- postgresql.service: - Add ProtectHome - use postgres instead of pg_ctl (http://www.postgresql.org/docs/9.4/static/server-start.html) - use $PGDATA (standard variable) instead of $PGROOT - Use RuntimeDirectory - remove postgresql.logrotate and postgresql.tmpfiles.conf (not needed anymore) Some possible improvements: - in .install, use sysusers.d. Is the fixed uid needed ? - postgresql-check-db-dir should read PGDATA from the environment. - update PKGBUILD to match changes Working on it. BTW, why use /var/lib/postgres/data and not /var/lib/postgres ? |
This task depends upon
Closed by Levente Polyak (anthraxx)
Wednesday, 13 March 2019, 22:47 GMT
Reason for closing: Implemented
Additional comments about closing: 11.2-1
any further suggestions go to separate tickets please
Wednesday, 13 March 2019, 22:47 GMT
Reason for closing: Implemented
Additional comments about closing: 11.2-1
any further suggestions go to separate tickets please
- Remove the fixed uid
- is 0750 right for /var/lib/postgres/data ?
Missing: update PKGBUILD (waiting for you approval)
postgresql.tmpfiles.conf (0 KiB)
Then, I think that the use of `/var/lib/postgres/data/` is one too many folder level, upstream recommended a `data` subfolder in case you were using `/usr/local/postgresql/` as "PGROOT". In which case you would have bin, lib… folders there, and then data one would make sense. But in our case, I would advocate using `/var/lib/postgres/`, even if that means having an update message in .install for the next release. And as stated before by @Yamakaky, the PGROOT variable is not standard, while PGDATA is recognized.
I can propose a reworked package, and can even split all of those changes as separated commits if you want.