FS#47398 - [firefox] Move gtk2 to make/optdepends

Attached to Project: Arch Linux
Opened by Balló György (City-busz) - Wednesday, 16 December 2015, 00:53 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 13 March 2018, 18:39 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Evangelos Foutras (foutrelis)
Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Apparently, Firefox works fine without gtk2 installed, so please move gtk2 from depends to makedepends and optdepends for GTK+ 2 plugins support.
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 13 March 2018, 18:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  firefox 59.0-1
Comment by Evangelos Foutras (foutrelis) - Wednesday, 16 December 2015, 07:27 GMT
From my post on a reddit thread:

"It needs to be a hard dependency because Firefox does not gracefully handle the case of missing GTK2 (it continuously tries to spawn the plugin using /usr/lib/firefox/plugin-container). Moreover, after installing GTK2 the Flash plugin does not work until pluginreg.dat has been deleted."

[1] https://www.reddit.com/r/archlinux/comments/3wxvna/arch_and_firefox_43_and_gtk3/cy02fgh
Comment by Eli Schwartz (eschwartz) - Tuesday, 02 January 2018, 12:55 GMT
So foutrelis confirmed on IRC that the first issue does seem to be fixed, and re: the second issue, the flashplugin dependency on gtk2 is sufficient to ensure the pluginreg.dat is correct. :)
Comment by Evangelos Foutras (foutrelis) - Tuesday, 02 January 2018, 12:59 GMT
I tested this again and the first issue appears to be solved. Firefox doesn't spawn plugin-container forever, it just marks the plugin as invalid upon startup if gtk2 is missing.

Now, about the pluginreg.dat issue, flashplugin is marked as invalid when it's encountered without gtk2. This can't happen since flashplugin depends on gtk2. If flashplugin+gtk2 is installed after firefox's first run, the plugin is correctly recognized and enabled.

Based on the above, gtk2 can be moved to makedepends. IMO it doesn't need to be listed as an optional dependency since the plugins themselves depend on gtk2. (This is the case for flashplugin and npapi-vlc, other plugins use qt4/5 and java.)
Comment by Emil (xexaxo) - Friday, 23 February 2018, 10:53 GMT
FWIW I just hacked the package dropping the GTK2 dependency (+removing GTK2 on my system) and it seems to work fine.
Comment by Bruno Pagani (ArchangeGabriel) - Sunday, 04 March 2018, 14:58 GMT
So, could gtk2 be removed from dependencies of all firefox* packages?

Loading...