FS#47149 - [patch] makepkg should not warn about dependency checks when used with -o/--nobuild

Attached to Project: Pacman
Opened by larchunix (larchunix) - Sunday, 22 November 2015, 18:29 GMT
Task Type Bug Report
Category makepkg
Status Unconfirmed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version git
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 1
Private No

Details

Summary and Info:

When used with -d/--nodeps, makepkg raise the following warning: "WARNING: Skipping dependency checks."

According a comment in makepkg's source code (https://projects.archlinux.org/pacman.git/tree/scripts/makepkg.sh.in?h=v4.2.1#n3605), makepkg's developers planned to hide this warning when makepkg is used with -o/--nobuild.

Indeed, this warning loses its meaning in this case and it could be misleading (full story here: https://github.com/archlinuxfr/yaourt/issues/155).

Please find attached a trivial patch which should do the trick.
   0001-makepkg-do-not-warn-abou... (0.8 KiB)
This task depends upon

Comment by Allan McRae (Allan) - Monday, 23 November 2015, 00:58 GMT
That was an intended change, but it seems the comment was forgotten.

See  FS#35057  and  FS#36999 
Comment by larchunix (larchunix) - Monday, 23 November 2015, 09:39 GMT
Would it be acceptable not to show this warning if both --nobuild and --noprepare are used ?

i.e:

if (( NODEPS && ( ! NOBUILD || PREPAREFUNC ) )); then
warning "$(gettext "Skipping dependency checks.")"
fi
Comment by Eli Schwartz (eschwartz) - Friday, 08 September 2017, 20:09 GMT
I'm not even sure I see the use case. prepare() is allowed to modify the pkgver= of a VCS package, you shouldn't be using --nodeps or --noprepare in this instance.

Loading...