FS#47147 - [youtube-dl] Optional dependency python-pyxattr missing

Attached to Project: Community Packages
Opened by Tobias Markus (netcrusher) - Sunday, 22 November 2015, 14:48 GMT
Last edited by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 01:57 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Eric Belanger (Snowman)
Jaroslav Lichtblau (Dragonlord)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
youtube-dl is missing its optional dependency on python-pyxattr.
python-pyxattr is required for the xattr-related flags --xattr-set-filesize and --xattrs.

Further information:
* youtube-dl manpage
* e.g. https://github.com/rg3/youtube-dl/blob/master/youtube_dl/downloader/http.py#L184
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Sunday, 10 September 2017, 01:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed upstream, see comments
Comment by Chih-Hsuan Yen (yan12125) - Thursday, 26 November 2015, 14:15 GMT
In fact it's a upstream bug. youtube-dl should fallback to call external programs for all xattr operations. (for example what XAttrMetadataPP does[1]). However, I or other youtube-dl developers may have no time to fix it.

If you're going to use python-pyxattr, remember to install version 0.5.0 or above. Earlier versions are not compatible with youtube-dl.

PS. I'm one of the collaborators of youtube-dl.

[1] https://github.com/rg3/youtube-dl/blob/master/youtube_dl/postprocessor/xattrpp.py
Comment by Eli Schwartz (eschwartz) - Friday, 08 September 2017, 19:58 GMT
I'm not sure what the problem is supposed to be here, since in youtube_dl/utils.py it falls back on running either setfattr or xattr (provided by python-xattr!!) in a subprocess rather than importing xattr.
(This was moved from xattrpp.py apparently but is still the same code, save that it later added compatibility with python-xattr in addition to python-pyxattr.)

And setfattr is part of the attr package which is required by acl, coreutils, libarchive, libcap, patch, sed, tar...
Comment by Chih-Hsuan Yen (yan12125) - Saturday, 09 September 2017, 15:05 GMT
Ah, I fixed the upstream bug in [1], several months after I open this ticket. Now it's no longer an Arch issue and you can close it :)

[1] https://github.com/rg3/youtube-dl/commit/d7753d194803086d97ffe47f022c47c906ebcc71
Comment by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 01:57 GMT
Aha, so the bug was because it originally didn't even properly use the generic extended attributes adapter... good to know, thanks!

Loading...