FS#46996 - [julia] Non-existing Make.inc targets, moving built doc and question about libgit2, cmake

Attached to Project: Community Packages
Opened by Lex Black (TrialnError) - Saturday, 07 November 2015, 12:15 GMT
Last edited by Alexander F. Rødseth (xyproto) - Sunday, 20 December 2015, 18:20 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Hi

Some points I noticed while comparing the AUR/julia-git package against the community/julia one (Reason because of the SSE2 thing and some more).

The setting of Make.inc USE_SYSTEM flags is out of date (with the release-0.4 Make.inc of course)

Settings like
USE_SYSTEM_READLINE=0 \
USE_SYSTEM_ZLIB=1 \
USE_SYSTEM_GRISU=0 \
USE_SYSTEM_RMATH=0 \

aren't available anymore and
USE_MKL=0 \

got renamed to USE_INTEL_MKL (Building with USE_MKL should make a note about that change)

And there are a few missing:
USE_SYSTEM_DSFMT=0 \
USE_SYSTEM_LIBGIT2
USE_SYSTEM_PATCHELF

Which brings me to the next point. Any reason not to use the arch libgit2 while building julia? If using it, it would remove the makedepend on cmake. Additionally since the move to libgit2 the dependency on git can be dropped/replaced with libgit2.

And why is libuv included in the deps, but not activated via USE_SYSTEM_LIBUV=1 ? (Although on that case my knowing was, that julia used an old fork of libuv and wasn't working the repo one).

Two more deps that could be included as USE_SYSTEM_..=1 are OPENLIBM and OPENSPECFUN. Both resides in the AUR and are used for the julia-git package. Although fairly said the gain is minimal.

Julia provides .desktop files and sorts, so namcap complains about a missing call to xdg-icon-resource forceupdate or the gtk based one.

In my opinion the optdepends line should move into the package_julia() function. Now the julia-docs packages also offers this optdepends which is kinda unnecessary.

And lastly.
Dunno about the build process with the pointed release. But before the release of 0.4 they changed some things with the doc building and in general the html doc is generated. If this also applies for the pointed release shouldn't this be copied to the julia-doc package?
This task depends upon

Closed by  Alexander F. Rødseth (xyproto)
Sunday, 20 December 2015, 18:20 GMT
Reason for closing:  Fixed
Comment by Lex Black (TrialnError) - Saturday, 07 November 2015, 12:21 GMT
Oh, missed one point.
USE_SYSTEM_BLAS could also be set to one. It is added on the depends line but in the build process disabled


Edit: And shouldn't the line, where make is called, $pkgname replaced with $pkgbase? It seems to be working, else there would be no package. But doesn't make the call of $pkgname return the array?

Edit2: And the lines
# Remove duplicate man-page from julia/doc
rm -rvf "$pkgdir/usr/share/julia/doc/man"
should be in the julia-docs package.
in the julia package those aren't make that much sense, because a few lines later the whole /usr/share/julia/doc folder will the removed

Edit3: Fix one word. Translated it into the wrong language *cough*
Comment by Lex Black (TrialnError) - Saturday, 14 November 2015, 21:16 GMT
Oh, and the pcre dependency should be removed. They switched from pcre to pcre2 and afaik the support for pcre is gone, just pcre2 needs to be there
Comment by Alexander F. Rødseth (xyproto) - Thursday, 19 November 2015, 10:59 GMT
Thanks for reporting! WIll fix.
Comment by Lex Black (TrialnError) - Sunday, 22 November 2015, 12:31 GMT
One note though.
Didn't thought about the fact, when Julia downloads it deps. They use for some git to clone the repos. Then git would remain as a makedep, but could still be removed as runtimedep

Loading...