FS#46863 - [openjdk8-src] lacks 'sun.*' sources

Attached to Project: Arch Linux
Opened by Alexandre Bury (gyscos) - Saturday, 24 October 2015, 22:47 GMT
Last edited by Toolybird (Toolybird) - Sunday, 04 June 2023, 04:06 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

The package `openjdk8-src` contains a `src.zip`, itself containing multiple source directories, but not `sun`.
However, it appears that upstream openjdk8 does contain this `sun` directory:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes

Additional info:
* Tested with `openjdk8-src` version `8.u65-1`.


Steps to reproduce:
* Install `openjdk8-src`
* Inspect `/usr/lib/jvm/java-8-openjdk/src.zip`
* Notice absence of a `sun` directory.

Remarks:
* The `src.zip` in package `openjdk7-src` does contain such a `sun` directory.
This task depends upon

Closed by  Toolybird (Toolybird)
Sunday, 04 June 2023, 04:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  See comments
Comment by Christian Demsar (crasm) - Tuesday, 25 April 2017, 22:26 GMT
I was recently hit by this when stepping through loading a resource file, since it ends up in sun.misc.URLClassLoader.

Investigating led me to jdk-jdk8u121-b13/make/CreateJars.gmk, which contains:
[...]
SRC_ZIP_INCLUDES = \
com/sun/corba \
[...]
java \
javax/accessibility \
[...]
org/ietf \
org/omg \
org/w3c/dom \
org/xml/sax \
#
[...]

If you add "sun \" to the end of the list and `makepkg -e`, the final zip will include the sun package java files. I don't think any patches or scripts are modifying CreateJars.gmk, so this is probably an upstream bug.

update:
Here's the upstream bug. It was fixed in jdk9: https://bugs.openjdk.java.net/browse/JDK-8044235
Here's some recent-ish discussion: http://marc.info/?l=openjdk-build-dev&m=148343073402469&w=2

The patch hasn't been accepted yet?
- as of this post: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/5534221c23fc/make/CreateJars.gmk
- latest: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/tip/make/CreateJars.gmk

Jetbrains openjdk8 is also missing the sources
- https://github.com/JetBrains/jdk8u_jdk/blob/addecb84df2170be6f33bfc50861031ad1d75529/make/CreateJars.gmk#L615
- https://github.com/JetBrains/jdk8u_jdk/blob/master/make/CreateJars.gmk#L615
Comment by Luc des Trois Maisons (ShroudedNight) - Tuesday, 15 September 2020, 15:11 GMT
This appears to be resolved.

The upstream bug report shows backports to 8u201 and 8u211, furthermore I see that the current version of the package does contain the sun directory.

Attached the results of `$ find sun -type f > sun.txt` against the extracted contents of src.zip.
   sun.txt (195.1 KiB)

Loading...