FS#46572 - [pulseaudio] Add whitespaces around = sign in custom conf

Attached to Project: Arch Linux
Opened by zopieux (Zopieux) - Monday, 05 October 2015, 21:48 GMT
Last edited by Jan Alexander Steffens (heftig) - Friday, 06 November 2015, 16:48 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:
pulseaudio configuration files usually have a single whitespace around the = sign, for example:

; exit-idle-time = 20

The current PKGBUILD (7.0 rev 2) uses sed to replace some lines with a non-default setting but there is no whitespace around the = sign. For instance:

sed -e '/flat-volumes/iflat-volumes=no' # snip

By not respecting pulseaudio default style, this creates annoying differences in configuration. My suggestion is to add whitespaces around = in all sed-ed lines. See attached patch.
   PKGBUILD.patch (0.5 KiB)
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Friday, 06 November 2015, 16:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in HEAD
Comment by Jan Alexander Steffens (heftig) - Tuesday, 06 October 2015, 00:46 GMT
I don't see how this would matter.
Comment by Christoph Gysin (christoph.gysin) - Monday, 02 November 2015, 18:12 GMT
While it does not change functionality, I think it is good practice to follow upstream's style.

Is there anything preventing merging this patch?

Loading...