FS#46390 - [x264] don't use $pkgname for paths in split packages
Attached to Project:
Arch Linux
Opened by Que Quotion (quequotion) - Tuesday, 22 September 2015, 06:35 GMT
Last edited by Doug Newgard (Scimmia) - Thursday, 29 October 2015, 14:58 GMT
Opened by Que Quotion (quequotion) - Tuesday, 22 September 2015, 06:35 GMT
Last edited by Doug Newgard (Scimmia) - Thursday, 29 October 2015, 14:58 GMT
|
Details
Description:
x264 needs pkgbase =('x264') and to use $pkgbase in pkgver(), prepare(), and build() If a user is building only one of the packages (makepkg --pkg libx264) $pkgname returns the name of the requested package, not the expected overall packge name ($pkgbase) Additional info: * package version(s) * config and/or log files etc. Steps to reproduce: Try to build libx264 from ABS |
This task depends upon
prepare() needs quotations around the directory names:
prepare() {
cp -r "$pkgbase" "$pkgbase-10bit"
}
Otherwise x264-10bit is created as a copy of x264 *with another copy inside it* and build will fail with:
gcc -o x264 x264.o input/input.o input/timecode.o input/raw.o input/y4m.o output/raw.o output/matroska.o output/matroska_ebml.o output/flv.o output/flv_bytestream.o filters/filters.o filters/video/video.o filters/video/source.o filters/video/internal.o filters/video/resize.o filters/video/cache.o filters/video/fix_vfr_pts.o filters/video/select_every.o filters/video/crop.o filters/video/depth.o input/avs.o input/thread.o input/lavf.o output/mp4_lsmash.o libx264.a -ldl -llsmash -lm -L. -lavformat -lavcodec -lavutil -lswscale -lswscale -lavutil -m64 -Wl,-O4,--sort-common,--as-needed,-z,relro -lm -lpthread
/usr/bin/ld: cannot open output file x264: Is a directory
collect2: error: ld returned 1 exit status
Makefile:200: recipe for target 'x264' failed
make: *** [x264] Error 1
==> ERROR: A failure occurred in build().
Are you not having the other problem?