FS#46223 : [nvidia] Suggestions on the new PKGBUILD

FS#46223 - [nvidia] Suggestions on the new PKGBUILD

Attached to Project: Arch Linux
Opened by Tom Yan (tom.ty89) - Tuesday, 08 September 2015, 04:00 GMT
Last edited by Felix Yan (felixonmars) - Thursday, 10 September 2015, 10:07 GMT

Task Type	General Gripe
Category	Packages: Testing
Status	Closed
Assigned To	Ionut Biru (wonder) Sven-Hendrik Haase (Svenstaro) Felix Yan (felixonmars)
Architecture	All
Severity	Low
Priority	Normal
Reported Version
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

1. eval "sed -i 's/__VERSION_STRING/${pkgver}/' dkms.conf"

The `eval` seems quite unnecessary. I think `sed -i "s/__VERSION_STRING/${pkgver}/" dkms.conf` (double quotes instead of single quotes) will do.

2. __JOBS

I wonder if it would be nice to directly sed the original __JOBS to `nproc`. The current way doesn't seem to make a point while dkms.conf is not in the backup array (i.e. if users aren't suppose to change it, why make it explicit?)

This task depends upon

Closed by Felix Yan (felixonmars)
Thursday, 10 September 2015, 10:07 GMT
Reason for closing: Implemented

Comment by Tom Yan (tom.ty89) - Tuesday, 08 September 2015, 04:31 GMT

Also, I think

sed -i 's/__DKMS_MODULES//' dkms.conf
sed -i '$iBUILT_MODULE_NAME[0]="nvidia"\
DEST_MODULE_LOCATION[0]="/kernel/drivers/video"\
BUILT_MODULE_NAME[1]="nvidia-uvm"\
DEST_MODULE_LOCATION[1]="/kernel/drivers/video"' dkms.conf

make the conf look more neat.

Comment by Tom Yan (tom.ty89) - Tuesday, 08 September 2015, 04:48 GMT

patch for PKGBUILD and sample generated conf