AUR web interface

Tasklist

FS#45834 - Remove trailing slash from git https://link.git/

Attached to Project: AUR web interface
Opened by Chris Severance (severach) - Thursday, 30 July 2015, 07:03 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 03 October 2015, 08:01 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 4.0.0-rc6
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Git Clone URL: https://aur4.archlinux.org/foo-git.git/ (read-only)
# git clone https://aur4.archlinux.org/foo-git.git/
# ls
foo-git.git

# git clone https://aur4.archlinux.org/foo-git.git
# ls
foo-git

The extra slash interferes with proper copy-paste.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Saturday, 03 October 2015, 08:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 4.1.0.
Comment by Lukas Fleischer (lfleischer) - Tuesday, 04 August 2015, 03:42 GMT
I cannot reproduce this, `git clone https://aur4.archlinux.org/foo-git.git/` works fine here (and produces a directory named foo-git). Which version of Git are you using? Are you running this from an up-to-date Arch Linux machine?
Comment by Doug Newgard (Scimmia) - Tuesday, 04 August 2015, 04:02 GMT
Reproducible here on an up to date system.
Comment by Lukas Fleischer (lfleischer) - Tuesday, 04 August 2015, 04:37 GMT
Looks it is me who wasn't up to date. The behavior changed in Git somewhere between 2.4.6 and 2.5.0. I reported this to the Git ML.
Comment by (Det) - Tuesday, 04 August 2015, 11:07 GMT
His report: http://marc.info/?l=git&m=143867348221782&w=2
Comment by Stefan Auditor (sanduhrs) - Wednesday, 12 August 2015, 11:23 GMT
Any reason not to remove the trailing slash?
In my eyes it looks odd to have one after a file extension.

Patch submitted: https://lists.archlinux.org/pipermail/aur-dev/2015-August/003701.html
Comment by Stefan Auditor (sanduhrs) - Friday, 14 August 2015, 08:00 GMT
All git hosting services I'm aware of do it that way.
The most famos examples being

Github
https://github.com/owner/repository.git
git@github.com:owner/repository.git

Gitlab
https://example.org/group/repository.git
git@example.org:group/repository.git

(Sorry for the cross post: https://lists.archlinux.org/pipermail/aur-dev/2015-August/003710.html)
Comment by Stefan Auditor (sanduhrs) - Sunday, 16 August 2015, 12:21 GMT
Updated patch according to the requirements expressed on aur-dev: https://lists.archlinux.org/pipermail/aur-dev/2015-August/003719.html
Comment by Chris Severance (severach) - Friday, 21 August 2015, 02:03 GMT
More trouble.

Why was git:// switched away from? Why was ssh+git:// chosen? Shouldn't this be git+ssh://? I can't find any examples of either git+ssh or ssh+git. The closest I can come is git+http which we use in the sources array.

Why are http: and ssh+git clickable links when they don't take you anywhere?

Loading...