FS#45311 - [umlet] *.orig from patching remains in package

Attached to Project: Community Packages
Opened by Sven Karsten Greiner (SammysHP) - Saturday, 13 June 2015, 08:52 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 15 June 2015, 13:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In the PKGBUILD: https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/umlet&id=1988d34f196c13d2e24c1e577b7a69747c066531

A file is patched during build() and in line 25 the *.orig file should be deleted, but it is not because the first letter is capitalized. In the next step during package() the directory is moved to the target location, thus the orig file is included in the package.

The main two issues:

- rm tries to remove the wrong file
- mv in line 34 might result in wrong file permissions
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 15 June 2015, 13:41 GMT
Reason for closing:  Fixed
Comment by Sven Karsten Greiner (SammysHP) - Saturday, 13 June 2015, 09:09 GMT
Another related issue: umlet.sh exists twice:

1. /usr/share/umlet/umlet.sh
2. /usr/bin/umlet

I suggest to symlink /usr/bin/umlet to /usr/share/umlet/umlet.sh or remove /usr/share/umlet/umlet.sh completely.
Comment by Sven Karsten Greiner (SammysHP) - Saturday, 13 June 2015, 09:50 GMT
Here is an updated package:

- version 13.2 -> 13.3
- patch from  FS#45312 
- cleaned up PKGBUILD
- remove unnecessary rm -rf
- remove *.orig
- remove duplicated umlet.sh
(application/x-gzip)    umlet.tar.gz (1.3 KiB)

Loading...