FS#45257 - [mpv] Is smbclient really necessary

Attached to Project: Community Packages
Opened by Neven Sajko (Neven) - Monday, 08 June 2015, 11:06 GMT
Last edited by Doug Newgard (Scimmia) - Saturday, 13 June 2015, 04:37 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Is smbclient really needed in depends?
It is huge and pulls in a lot of deps of its own,
and I don't think it represents mpv's primary functionality.
This task depends upon

Closed by  Doug Newgard (Scimmia)
Saturday, 13 June 2015, 04:37 GMT
Reason for closing:  Not a bug
Comment by Karol Błażewicz (karol) - Monday, 08 June 2015, 11:19 GMT
There's https://aur.archlinux.org/packages/mpv-git/
Comment by wtf (oi_wtf) - Monday, 08 June 2015, 19:08 GMT
If you want to play files on smb-shares, it's needed.
Filemanagers will pass smb:// url to mpv because its desktop file states that mpv can handle urls.
If compiled without smb-support, mpv won't play any file on smb-shares,
because it can't handle the smb-url given by filemanagers.

Since I'm using mpv to play videos shared using smb quite regularly, I'd be sad to see support for that gone.
And none of my machines got a full SDD just because of those few MiB of libs smbclient depends on.
That shouldn't be any issue any more when even most SSDs cost less than a dollar per gigabyte, with HDDs it's even around 5 cts per GB.
Comment by Doug Newgard (Scimmia) - Tuesday, 09 June 2015, 03:44 GMT
The mpv executable and libmpv.so.16.0 both link to libsmbclient.so.0. This means that when mpv is built with smbclient support, it's required for the program to even run. As this is a feature that was requested many, many times, I think you'd need a pretty good argument for getting rid of it. Care to give it a shot?

You can always use the ABS or one of it's alternatives to rebuild the package however you want.

Loading...