FS#45044 - [puppet] systemd service file for puppet agent has wrong path

Attached to Project: Community Packages
Opened by Michael Gisbers (mgisbers) - Thursday, 21 May 2015, 14:03 GMT
Last edited by Jonathan Steel (jsteel) - Saturday, 23 May 2015, 08:36 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jonathan Steel (jsteel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Path within systemd service file does not use corrct path to puppet binary. Because of that the puppet agent cannot be started with 'systemctl start puppet.service'.

Service file for puppet master is correct and works as expected.

Additional info:
* 4.0.0-2

Steps to reproduce:

wrong line within /usr/lib/systemd/system/puppet.service:
ExecStart=/opt/puppetlabs/puppet/bin/puppet agent $PUPPET_EXTRA_OPTS --no-daemonize

should be:
ExecStart=/usr/bin/puppet agent $PUPPET_EXTRA_OPTS --no-daemonize

after changing that line, 'systemctl daemon-reload' service starts without problems.
This task depends upon

Closed by  Jonathan Steel (jsteel)
Saturday, 23 May 2015, 08:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed version moved to [community]
Comment by Doug Newgard (Scimmia) - Thursday, 21 May 2015, 14:16 GMT
This service file comes from upstream. You might want to report this to them as well, they're making some big assumptions in how it's going to be installed.
Comment by Michael Gisbers (mgisbers) - Thursday, 21 May 2015, 14:54 GMT
Your totally right pointing me to upstream. But in upstream they recently changed the path to use AIO (All In One) packaging of puppet agent along with facter, hiera, etc. in /opt/puppetabs/puppet. The actual arch package does not provide the AIO package but the full installation.

Based on not using the AIO feature the path in puppet.service should be changed to the /usr/bin/puppet binary.
Comment by Jonathan Steel (jsteel) - Thursday, 21 May 2015, 15:05 GMT
The tar file used (that includes this file) is not the AIO package though. In any case I'll patch this file when I update to 4.1.0 later today. Still worth reporting upstream though, to ship the correct service file for the standalone package.
Comment by Jonathan Steel (jsteel) - Thursday, 21 May 2015, 17:25 GMT
Fixed in puppet-4.1.0-1 in [community-testing]

Loading...