FS#45042 - pacmatic 20150126-1, optionally depends vim, but is actually required
Attached to Project:
Community Packages
Opened by Dan Örjestad (kiipa) - Thursday, 21 May 2015, 12:38 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 09 August 2017, 04:51 GMT
Opened by Dan Örjestad (kiipa) - Thursday, 21 May 2015, 12:38 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 09 August 2017, 04:51 GMT
|
Details
Description:
The pacmatic package (from the offical repo) has vim listed as an optional dep, but when trying to update the new without vim this message appears: "6 pacnew files found (0 added). Update files now? (Y/n) y ==> ERROR: Cannot find the vim -d binary required for viewing differences." Additional info: * package version(s): 20150126-1 Steps to reproduce: Install pacmatic from offical repo, remove vim if not installed and run "pacmatic -Syu". |
This task depends upon
Closed by Eli Schwartz (eschwartz)
Wednesday, 09 August 2017, 04:51 GMT
Reason for closing: Not a bug
Wednesday, 09 August 2017, 04:51 GMT
Reason for closing: Not a bug
2) You can override $DIFFPROG with something non-vim.
I am open to suggestions for how you would like it to actually work, but vim is already pretty optional.
But I think it'd be a good idea to first check if vim is available, if not then don't prompt to update the files but instead print a notice about it (that you need vim or similar to complete that stage) and continue.
Pacmatic could have a very fragile check that can only handle one default case, or pacdiff could be patched to more gracefully deal with a missing $DIFFPROG. I would suggest the second option.