FS#44751 - [chrony] redundant conf file editing in prepare()

Attached to Project: Community Packages
Opened by Neven Sajko (Neven) - Monday, 27 April 2015, 21:32 GMT
Last edited by Sergej Pupykin (sergej) - Tuesday, 28 April 2015, 15:49 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

The line
echo -e "\n# Enable kernel RTC sync\nrtcsync" >> "$pkgdir/etc/chrony.conf"
in the PKGBUILD is redundant with the 2.0 release.
This task depends upon

Closed by  Sergej Pupykin (sergej)
Tuesday, 28 April 2015, 15:49 GMT
Reason for closing:  Fixed
Comment by Neven Sajko (Neven) - Monday, 27 April 2015, 23:56 GMT
Actually, the line
echo -e "\n# Enable kernel RTC sync\nrtcsync" >> "$pkgdir/etc/chrony.conf"
is in package()
Comment by Neven Sajko (Neven) - Monday, 27 April 2015, 23:59 GMT
There's another mistake in the PKGBUILD regarding the configuration file:
sed -i 's|.pool.ntp.org|.arch.pool.ntp.org|g' examples/chrony.conf.example*
should probably be something like
sed -i 's|pool.ntp.org|arch.pool.ntp.org|g' examples/chrony.conf.example1
because it replaces the space between the 'pool' directive and argument with '.' .
Comment by Neven Sajko (Neven) - Tuesday, 28 April 2015, 00:03 GMT
And also the rtconutc option isn't in in chrony.conf.example1 .
Comment by Neven Sajko (Neven) - Tuesday, 28 April 2015, 00:05 GMT
You could change the PKGBUILD less if you used the old conf which is now chrony.conf.example3 .
Comment by Troy Engel (TE) - Tuesday, 28 April 2015, 01:01 GMT
I just came to report this regression as well -- the PKGBUILD was updated to use chrony.conf.example1 but it should have chosen chrony.conf.example3 to maintain backwards compatibility with existing users during upgrade. The extra examples should then be added to the package under /usr/share/doc/chrony/examples/ to let a user then choose their own other config if the fully commented example3 is "too much" post-install. Also -- example3 is the only one that contains defaults for "offline" mode which works for laptop users (and the network manager dispatcher script).
Comment by Sergej Pupykin (sergej) - Tuesday, 28 April 2015, 11:44 GMT
I've changed example to 3 and install examples into /usr/share/doc/chrony/examples. Please try 2.0-2
Comment by Neven Sajko (Neven) - Tuesday, 28 April 2015, 13:57 GMT
The bad sed edits from my 2nd comment are still here.
Like this:
! pool.arch.pool.ntp.org iburst
(with a '.' instead of a ' ').
Comment by Neven Sajko (Neven) - Tuesday, 28 April 2015, 13:59 GMT
And there are some namcap errors, dunno if you've seen those.
Comment by Sergej Pupykin (sergej) - Tuesday, 28 April 2015, 14:04 GMT
should be fixed in 2.0-3
Comment by Neven Sajko (Neven) - Tuesday, 28 April 2015, 15:20 GMT
Thanks!
Seems fine now

Loading...