FS#44516 - [unittestpp] wrong directory for include files and missing include-file UnitTest++.h

Attached to Project: Community Packages
Opened by Uwe Koloska (kolewu) - Thursday, 09 April 2015, 21:05 GMT
Last edited by Eli Schwartz (eschwartz) - Thursday, 03 August 2017, 22:51 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Upstream (now on github -- see my other report https://bugs.archlinux.org/task/44514) installs include files in include/UnitTest++ (see: https://github.com/unittest-cpp/unittest-cpp/blob/master/CMakeLists.txt#L51 -- that's a new addition, but if I remember correctly intended before) and this has been the case with the AUR package 1.4-2 as well. (the AUR version 1.4-3 changed that though)

Don't know whether there is an Arch rule that permits mixed case for include directories -- but then there are some more packages that do break this rule:
find /usr/include/ -type d -a -name "[A-Z]*"

I don't think it's a good idea to change an include directories name.

Searching for all relevant information, I found that there is a file missing in the package: UnitTest++.h that is mentioned in the documentation: /usr/share/doc/unittestpp/UnitTest++.html (but it's not in the new install-target -- what a mess ...)

Some searching later: since all include files are now in one directory and this include directory is reported correctly by pkg-config (and my package lenmus get's it right in the cmake search), it's not as important what the name is -- but I would prefer the name that upstream has chosen.

Additional info:
* 1.4-6
* commit of the install target: https://github.com/unittest-cpp/unittest-cpp/commit/13a6c9e6ada95a291cdcf132ba2a0122f4a924a7
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Thursday, 03 August 2017, 22:51 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed pc file: unittestpp 1.6.1-1
fixed installation directory: unittestpp 2.0.0-1
Comment by TingPing (TingPing) - Thursday, 02 February 2017, 07:58 GMT
The pc file is part of the Arch package so it is simply wrong and all that is needed is:

-Cflags: -I${includedir}/unittest++
+Cflags: -I${includedir}/UnitTest++
Comment by TingPing (TingPing) - Thursday, 02 February 2017, 14:02 GMT
On a related note upstream does have a pc file and it is uppercase UnitTest++.pc so that should probably be used.

Loading...