FS#44438 - [devtools] makechrootpkg: allow --noextract

Attached to Project: Arch Linux
Opened by Serge Roussak (beaux_monde) - Thursday, 02 April 2015, 13:21 GMT
Last edited by Kristian (klausenbusk) - Saturday, 03 June 2023, 18:07 GMT
Task Type Feature Request
Category Arch Projects
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

In the version 20150228 of the devtools package there is no an ability to pass the --noextract switch to the makepkg because makechrootpkg removes the build dir anyway. I propose to apply the given patch.
   add-noextract-support.patch (1.7 KiB)
This task depends upon

Closed by  Kristian (klausenbusk)
Saturday, 03 June 2023, 18:07 GMT
Reason for closing:  Upstream
Additional comments about closing:  Please report upstream if this is still relevant: https://gitlab.archlinux.org/archlinux/d evtools.
Comment by Doug Newgard (Scimmia) - Wednesday, 13 May 2015, 20:16 GMT
Patches should be sent to the arch-projects mailing list.
Comment by Daniel Hahler (blueyed) - Thursday, 12 January 2017, 00:52 GMT
Serge, have you forwarded it to the mailing list already?

Since it basically disables the `rm -rf "$copydir/build"` I've tried it to make the following work (working on the awesome-luajit-git AUR package):

> extra-x86_64-build -- -T -I ~/.cache/pacaur/luajit-lgi/luajit-lgi-0.9.1-1-x86_64.pkg.tar.xz -- -e

But I am still getting:

==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> ERROR: pkgver is not allowed to contain colons, hyphens or whitespace.
==> ERROR: pkgver() generated an invalid version: /startdir/PKGBUILD: line 35: cd: awesome-luajit-git: No such file or directory
```

Probably also `-d` has to be used, but it failed with a permission error:

```
% extra-x86_64-build -- -T -I ~/.cache/pacaur/luajit-lgi/luajit-lgi-0.9.1-1-x86_64.pkg.tar.xz -d $PWD/src:/build/awesome-luajit-git/src -- -e
...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
mkdir: cannot create directory '/build/awesome-luajit-git/pkg': Permission denied

```

Using `-d $PWD:/build/awesome-luajit-git` works however.
If that is sane, it should be done automatically when using `-e` probably?!
Comment by Serge Roussak (beaux_monde) - Thursday, 12 January 2017, 06:41 GMT
Daniel, no I did not. But whether this (my) patch was applied to the official package?
Comment by Eli Schwartz (eschwartz) - Monday, 21 August 2017, 21:53 GMT
-*e* matches longopts too, which is... bad.

Also needs to be rebased.

...

Personally I see nothing wrong with only matching the longopt --noextract and not the shortopt.

EDIT: makepkg 5.1 has a separate parseopts library which should be used on general principle, and can also probably help split apart the options so you can match on -R|--repackage|-e|--noextract without any globs at all.

Loading...