FS#44429 - [firefox] Add desktop actions support

Attached to Project: Arch Linux
Opened by Konstantin (rilian_la_te) - Wednesday, 01 April 2015, 13:48 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 21 April 2015, 01:06 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Ionut Biru (wonder)
Evangelos Foutras (foutrelis)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Add some Desktop Actions Shortcuts to Firefox

I have attached example patch for it.
   firefox-desktop-actions.patch (0.9 KiB)
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 21 April 2015, 01:06 GMT
Reason for closing:  Implemented
Additional comments about closing:  firefox 37.0.1-2
Comment by Konstantin (rilian_la_te) - Saturday, 04 April 2015, 10:58 GMT
  • Field changed: Percent Complete (100% → 0%)
What about NewTab and Preferences?
Comment by Evangelos Foutras (foutrelis) - Saturday, 04 April 2015, 11:06 GMT
I only added the actions that Ubuntu's firefox.desktop file had.

I'll try to add a NewTab action since Firefox on Windows has it, but I won't be adding a Preferences action.
Comment by Konstantin (rilian_la_te) - Saturday, 04 April 2015, 11:48 GMT
Why? I succesfully added it in my example patch:) (But this is not localized, however)
Comment by Evangelos Foutras (foutrelis) - Saturday, 04 April 2015, 12:18 GMT
I prefer to stick to the actions that Firefox uses on Windows and, in a sense, are defined by upstream. It also might not fit the purpose that application actions serve.

NewTab action added in /trunk, will be in firefox 37.0.1-2 in a few days (part of ICU 55.1 rebuilds):

https://lists.archlinux.org/pipermail/arch-commits/2015-April/275699.html
Comment by Konstantin (rilian_la_te) - Saturday, 04 April 2015, 13:44 GMT
I do not know what actions firefox used on Windows, sorry. But preferences action is supported by firefox commandline, I see.
And adding a such action will be easy.
Comment by Evangelos Foutras (foutrelis) - Saturday, 04 April 2015, 14:05 GMT
Sorry, but I'm not going to add any other actions for reasons mentioned in my previous comment (following upstream, not abusing application actions).

For the record, on Windows Firefox provides these actions: Open new tab, Open new window, New private window. [1]

I'll leave this task open until firefox-37.0.1-2 moves to the stable repos in a few days.

[1] http://hg.mozilla.org/mozilla-central/file/944fb6e682b8/browser/locales/en-US/chrome/browser/taskbar.properties

Loading...