FS#44319 - [liblouis] Please add with enable-ucs4 option in Liblouis configuration options before build

Attached to Project: Arch Linux
Opened by Attila Hammer (hammera) - Tuesday, 24 March 2015, 10:07 GMT
Last edited by Antonio Rojas (arojas) - Saturday, 19 August 2017, 09:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Antonio Rojas (arojas)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Dear Maintainers,

If in Linux i686 or X86_64 architectures Liblouis package compiled without --enable-ucs4 option, with Orca Screen Reader not working right the contracted braille feature.
Testcase with Liblouis 2.5.2-3 or higher version related (both Manjaro and Arch this package version is available):
1. In terminal launch python3 interpreter, and paste following code:
from louis import translateString
print(translateString(['en-us-g2.ctb'], 'apple', None, 0))
Expected result:
Your screen or your braille display need presents the apple text.
Actual result:
Only presenting the a letter.

If I compiling latest Liblouis release with following option, my testcase run correct:
./configure --prefix=/usr --enable-ucs4

If I reinstalling Liblouis with this compilation options, when I running my test code, right presents the apple text.

Note:
With Liblouis upstream level already awailable the 2.6.2 version, but the ARCH Liblouis pkgbuild file used download URL is changed (I think the pkgbuild file have the old googlecode related download URL).
Newest Liblouis releases are possible downloading with following style URLS:
1. Source code repository moved from svn to github, URL is following:
https://github.com/liblouis/liblouis

2. Stable releases main URL is following:
https://github.com/liblouis/liblouis/releases

3. The actual latest stable release URL is following, I don't no possible automating future the Liblouis package update with pkgbuild files) this style urls:
https://github.com/liblouis/liblouis/releases/download/v2.6.2/liblouis-2.6.2.tar.gz

Sorry the combined report, but hopefuly this last informations is useful future with easying Liblouis packages maintaining.
If need anything testing before repository uploading, I have possibility only with Manjaro system testing the changes.

Attila
This task depends upon

Closed by  Antonio Rojas (arojas)
Saturday, 19 August 2017, 09:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  liblouis 3.2.0-1
Comment by Attila Hammer (hammera) - Tuesday, 24 March 2015, 10:11 GMT
This attachment containing the testing code. Enough to run the script with python3 liblouis_test.py to see the actual and changed result.
Comment by Attila Hammer (hammera) - Tuesday, 24 March 2015, 13:07 GMT
Please review this patch, only the PKGBUILD files happened smaller changes.
My local x86_64 Manjaro system if I using this modified PKGBUILD file, makepkg right building latest liblouis-2.6.2 release.
The local system installed package my system works correct.
Both I attached testcase rans correct,, and Orca Screen Reader works right the contracted braille feature if I using the modified package.
If need changing anything the patch, please tell me and I welcome doing the required changes.
If entire good my patch, please commit the package repository and do an update in extra repository to Arch users get latest Liblouis 2.6.2 release.

Attila
Comment by Attila Hammer (hammera) - Friday, 14 August 2015, 11:33 GMT
The Liblouis version my Manjaro system updated with 2.6.3-1 package version, but the problem is following:
When I toggled on contracted braille feature in Orca screen reader, the contracted braille feature not working me, I see only one character my phisical braille display.
Because Orca Screen Reader using Liblouis Python3 binding to generate contracted translated braille output, I fast doed a little test program to test Liblouis forward translation.
The test program code is following:
#!coding: UTF-8
import louis, sys
text=sys.argv[1]
print ('Translated Liblouis braille output: '+louis.translateString(['en-us-g1.ctb'], text, None, 0))

If I ran Python3 liblouis_test.py apple command, I get following traceback error message:
Traceback (most recent call last):
File "/run/media/belin/BeLin-4.01-amd64/liblouis_test.py", line 4, in <module>
print ('Translated Liblouis braille output: '+louis.translateString(['en-us-g1.ctb'], text, None, 0))
File "/usr/lib/python3.4/site-packages/louis/__init__.py", line 178, in translateString
return outbuf.value
ValueError: character U+61003b is not in range [U+0000; U+10ffff]

The test program expected output is following:
Translated Liblouis braille output: apple

If I recompile Liblouis from source with --prefix=/usr --enable-ucs4 configure parameters, all works fine me, both my test program and Orca contracted braille support.
Now, what configuration options have in Liblouis related PKGBUILD file?
In Ubuntu and Debian releases the --enable-ucs4 option is used before Liblouis compilation.
I using a 64 bit Manjaro release.

Attila
Comment by Ramon Buldó (kirek) - Friday, 14 August 2015, 17:16 GMT
python2 (https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/python2#n68) and python3 (seems to be the default) are compiled with ucs4 support, so I don't see why liblouis isn't compiled with ucs4 support.
Comment by Attila Hammer (hammera) - Saturday, 15 August 2015, 08:12 GMT
With python2 package PKGBUILD file in the configure section containing the --enable-unicode=ucs4 option, the python package related PKGBUILD file (the 3.4.3 version) not have this compilation flag.
The Liblouis PKGBUILD file in make depends section containing both python2 and python packages with build dependency.
I tryed remove the python2 package related parts from the Liblouis PKGBUILD file (the build depend and install parts), but without the enable-ucs4 configuration option I experience the quoted traceback error message when I ran python3 liblouis_test.py apple command.
So, real need I think the liblouis package the --enable-ucs4 option.

Attila
Comment by Ramon Buldó (kirek) - Monday, 29 February 2016, 19:31 GMT
Can this be addressed and the package compiled with ucs4 support, this task has been open for months...

Both python2 and python3 are compiled with ucs4 in arch so I don't see why this can't be done.

In Manjaro we have been recompiling this package with the --enable-ucs4 flag without any problem since this bug report was created.
Comment by Peter Vágner (pvagner) - Thursday, 05 May 2016, 17:20 GMT
I've recently also ran to this issue and I would like to get it fixed too.
I've noticed Antonio Rojas has made recent update to the liblouis package. Is it a good idea try tallking to him directly?
I think this is such a minor change that just anyone with arch linux commit access can fix.
Should we do something to better describe the issue or help to address it in a constructive way?

Loading...