FS#43931 - [netctl] mobile_ppp connection fails due to improperly quoted AT+CGDCONT argument (patch inside)

Attached to Project: Arch Linux
Opened by Jan Böcker (jboecker) - Tuesday, 24 February 2015, 17:35 GMT
Last edited by Jouke Witteveen (jouke) - Tuesday, 03 March 2015, 09:49 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Jouke Witteveen (jouke)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
On my Thinkpad X61t which has an integrated 3G modem, a mobile_ppp connection profile that has been working fine before stopped working a while ago.

Running with PPPDebug=true (log attached) revealed that the modem chokes on this AT command:

AT+CGDCONT=1,IP,"internet.eplus.de"

It wants the IP argument to be quoted. The following modification to line 67 of /usr/lib/network/connections/mobile_ppp fixed it for me:

$ diff /usr/lib/network/connections/mobile_ppp.bak /usr/lib/network/connections/mobile_ppp
67c67
< ${AccessPointName:+'OK-AT-OK' 'AT+CGDCONT=1,"IP",$(quote_word "$AccessPointName")'}
---
> ${AccessPointName:+'OK-AT-OK' 'AT+CGDCONT=1,$(quote_word "IP"),$(quote_word "$AccessPointName")'}

netctl version: 1.10-1

Please let me know if you need additional information or there is a more appropriate way to submit patches.
   PPPDebug.txt (4.3 KiB)
This task depends upon

Closed by  Jouke Witteveen (jouke)
Tuesday, 03 March 2015, 09:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  0491764
Comment by Jan Böcker (jboecker) - Tuesday, 24 February 2015, 17:38 GMT
Ignore the "abort on (BUSYARGH)" line in PPPDebug.txt. That was a test modification to confirm I was editing the correct file.
Comment by Jouke Witteveen (jouke) - Wednesday, 25 February 2015, 08:13 GMT
You are right, thanks for researching the root cause of your problem!
I will push a new version as soon as I have time. If you want your name and e-mail attached to your patch, you should send it in `git --format-patch` format to arch-projects@archlinux.org.
Comment by Jan Böcker (jboecker) - Wednesday, 25 February 2015, 14:34 GMT
Patch sent.
Thank you for maintaining netctl!

Loading...