FS#43395 - [makepkg] new staticlibs behavior does not work as expected

Attached to Project: Pacman
Opened by Andrea Scarpino (BaSh) - Saturday, 10 January 2015, 08:19 GMT
Last edited by Allan McRae (Allan) - Thursday, 12 February 2015, 04:21 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 4.2.0
Due in Version 4.2.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
I just updated libspnav in [extra] and I had to manually remove the static lib in package() because makepkg keep it.
I guess there's something wrong with the new behavior introduced with fe824f87b9f1e40d88bd1a190a0bc1c80f2e91eb.

Steps to Reproduce:
- Get libspnav PKGBUILD
- Drop the rm line in package()
- makepkg
- the built package contains both the dynamic AND static library.
This task depends upon

Closed by  Allan McRae (Allan)
Thursday, 12 February 2015, 04:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  git commit 9e5e86aa14 and 10fc538c7
Comment by Allan McRae (Allan) - Saturday, 10 January 2015, 09:05 GMT
Why did you remove "Makefile.patch" from SVN - it won't build at all now...
Comment by Andrea Scarpino (BaSh) - Saturday, 10 January 2015, 09:07 GMT
Ouch, forgot to push the edited version.
Comment by Andrea Scarpino (BaSh) - Saturday, 10 January 2015, 09:10 GMT
Pushed.
Comment by Allan McRae (Allan) - Saturday, 10 January 2015, 09:23 GMT
/usr/lib/libspnav.so -> /usr/lib/libspnav.so.0

So your package used symbolic links to the full path. Makepkg tests if libspnav.so exists but that resolved to /usr/lib/libspnav.so.0 which does not exist at that time. If it used a relative path for its symlink (which it should), makepkg is fine.

I'll add a workaround to makepkg, but this should be also fixed upstream.

Comment by Andrea Scarpino (BaSh) - Saturday, 10 January 2015, 09:28 GMT
Ah gotcha! Thanks for the explanation. I'll report upstream.

Loading...