FS#42926 - [mpv] add smb support

Attached to Project: Community Packages
Opened by Simon (smf) - Thursday, 27 November 2014, 12:02 GMT
Last edited by Christian Hesse (eworm) - Thursday, 12 March 2015, 11:01 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Christian Hesse (eworm)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:
mpv is compiled without smb (smbclient) support.
When running
mpv smb://
I get the message
No protocol handler found to open URL smb://
The protocol is either unsupported, or was disabled at compile-time.

Additional info:
* mpv 0.7.0-2
* smbclient 4.1.13-1

Steps to reproduce:
Install both, no smb:// support. It is enabled for mpv-git on AUR.
This task depends upon

Closed by  Christian Hesse (eworm)
Thursday, 12 March 2015, 11:01 GMT
Reason for closing:  Implemented
Additional comments about closing:  mpv 0.8.2-3 in [community-testing]
Comment by Florian Jacob (fjacob) - Sunday, 08 March 2015, 05:06 GMT
Are there any _reasons_ for not enabling smb support?

If there are, smb needs to be removed from
X-KDE-Protocols in
/usr/share/applications/mpv.desktop so that at least KIO can copy the file and play it back afterwards.
Comment by Doug Newgard (Scimmia) - Sunday, 08 March 2015, 05:07 GMT
Re-opened mostly because of the mpv.desktop complaint.
Comment by Florian Jacob (fjacob) - Wednesday, 11 March 2015, 10:15 GMT
Excuse my tone in my last comment, I was a little frustrated when I understood out it was the missing compile time option and then found this bug report closed with „won't implement“ without telling the reason why it won't be implemented.

Refering to https://aur.archlinux.org/packages/mp/mpv-git/PKGBUILD ,
wouldn't it be possible to add

CFLAGS="$CFLAGS -I/usr/include/samba-4.0"

to link mpv against samba and have smbclient as an optdepend?


What I'm actually trying to do:
* browse a smb:// share with dolphin, the KDE file manager
* click on a remote file / open it with mpv
* nothing happens

I found out this is because smb is listed in X-KDE-Protocols in /usr/share/applications/mpv.desktop ,
which makes KDE think that mpv supports smb:// urls natively. Therefore it calls

mpv "smb://examplehost/exampleshare/video.mkv"

which fails due to missing smb support.


If smb is removed from X-KDE-Protocols, KDE copies the whole file to /tmp and afterwards calls

mpv "/tmp/kde/video.mkv"

- which is good for normal-sized files that you need as a whole to display / edit anyway, but takes a while for big video files, where streaming would make more sense. But at least it would work that way.
Comment by Bartłomiej Piotrowski (Barthalion) - Wednesday, 11 March 2015, 10:31 GMT
Smbclient dependency is indeed optional when built this way. I'll push new packages shortly.
Comment by Bartłomiej Piotrowski (Barthalion) - Wednesday, 11 March 2015, 10:35 GMT
Or I won't. Namcap wrongly detects smbclient as an optdep, while in fact it isn't. As it's not my package anymore, I leave the decision to Christian.

Loading...