FS#42855 - [uwsgi] Wrong service file

Attached to Project: Community Packages
Opened by silverwyrda (SilverWyrda) - Thursday, 20 November 2014, 03:40 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 27 November 2014, 15:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Daniel Wallace (gtmanfred)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
There are several errors in the service file uwsgi@.service. First of all, a mistake in the path to the .ini config files in ExecStop and ExecReload. Then, the two commands invoked MUST have as an argument the master pid file.

Consequently, I would recommend to use the linked service file which solves this issue.
   uwsgi@.service (0.4 KiB)
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Thursday, 27 November 2014, 15:35 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 20 November 2014, 16:52 GMT
Thanks for having a look at that. Frankly I never used the @ service because I don't see a use case starting it for specific services as I use the emperor for that. I would like to recommend we use this instead:

ExecStart=/usr/bin/uwsgi --ini /etc/uwsgi/%I.ini
ExecReload=/usr/bin/uwsgi --ini /etc/uwsgi/%I.ini --reload $MAINPID
ExecStop=-/usr/bin/uwsgi --ini /etc/uwsgi/%I.ini --stop $MAINPID

This uses systemd's $MAINPID magic variable which doesn't require an extra file on the disk. Thoughts?
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 20 November 2014, 16:53 GMT
Also, since you seem to be using this, please take a look at the uwsgi in testing. It does things quite a bit differently.
Comment by silverwyrda (SilverWyrda) - Sunday, 23 November 2014, 16:08 GMT
Oups. Not a good idea since --reload/--stop opts require a file. However, I attached a solution using the signals.

I'll look at the one in testing.
   uwsgi@.service (0.3 KiB)

Loading...