FS#42795 - [fltk] tigervnc segfaults after pacman -Syu

Attached to Project: Arch Linux
Opened by Robot Anarchy (robotanarchy) - Saturday, 15 November 2014, 10:51 GMT
Last edited by Gerardo Exequiel Pozzi (djgera) - Saturday, 26 September 2015, 19:03 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

After running pacman -Syu, tigervnc (1.3.1-6) segfaults on successful connection:

TigerVNC Viewer 64-bit v1.3.1 (20140929)
Built on Sep 29 2014 at 14:46:36
Copyright (C) 1999-2011 TigerVNC Team and many others (see README.txt)
See http://www.tigervnc.org for information on TigerVNC.

Sat Nov 15 11:40:36 2014
CConn: connected to host 192.168.1.13 port 5900
CConnection: Server supports RFB protocol version 3.8
CConnection: Using RFB protocol version 3.8
[1] 22780 segmentation fault (core dumped) vncviewer 192.168.1.13


Here's the list of recently upgraded packages (I suspect the fltk update causes the segfault?), taken from /var/log/pacman.log:

[2014-11-14 23:08] [PACMAN] synchronizing package lists
[2014-11-14 23:09] [PACMAN] starting full system upgrade
[2014-11-14 23:09] [PACMAN] upgraded bluez-libs (5.25-1 -> 5.25-2)
[2014-11-14 23:09] [PACMAN] upgraded bluez-utils (5.25-1 -> 5.25-2)
[2014-11-14 23:09] [PACMAN] upgraded libcups (2.0.0-2 -> 2.0.0-3)
[2014-11-14 23:09] [PACMAN] upgraded cups (2.0.0-2 -> 2.0.0-3)
[2014-11-14 23:09] [PACMAN] upgraded file (5.20-1 -> 5.20-2)
[2014-11-14 23:09] [PACMAN] upgraded fltk (1.3.2-5 -> 1.3.3-1)
[2014-11-14 23:09] [PACMAN] upgraded imagemagick (6.8.9.9-1 -> 6.8.9.10-1)
[2014-11-14 23:09] [PACMAN] upgraded libevdev (1.3-1 -> 1.3.1-1)
[2014-11-14 23:09] [PACMAN] upgraded libxdg-basedir (1.2.0-2 -> 1.2.0-3)
[2014-11-14 23:09] [PACMAN] upgraded mutagen (1.25.1-1 -> 1.26-1)


PS: This package is in community, but I can't choose this as category. Sorry if I filed this wrong.
This task depends upon

Closed by  Gerardo Exequiel Pozzi (djgera)
Saturday, 26 September 2015, 19:03 GMT
Reason for closing:  Fixed
Comment by Robot Anarchy (robotanarchy) - Saturday, 15 November 2014, 11:05 GMT
I have recompiled the tigervnc package, as I thought this would solve the problem. but it does not, it still segfaults!

After downgrading fltk, tigervnc works again.

I guess this is an upstream bug?
Comment by Robot Anarchy (robotanarchy) - Saturday, 15 November 2014, 11:13 GMT
Made an upstream bug report:
https://github.com/TigerVNC/tigervnc/issues/72
Comment by Eric Belanger (Snowman) - Saturday, 15 November 2014, 15:33 GMT
There was a tigervnc.patch patch in the old fltk package. It looked like it was included upstream in 1.3.3 but it seem like it was not completely included. I'll need to update the patch.
Comment by John (graysky) - Saturday, 15 November 2014, 16:40 GMT
In addition to segfaulting, fltk-1.3.3-1 breaks any combination of ctrl + another key when connected to a tigervnc server. Downgrading to 1.3.2-5 fixes the problem. Not sure if this is an upstream regression or something patch we are not applying.

My  FS#42796  was found to a dup of this one, but I want to capture the ctrl issue here so all the info is in one place.

Steps to reproduce:
1) Install tigervnc and a DE ... on my box it runs lxde.
2) My ~/.vnc/xstartup contains online 1 line: exec startlxde and is started with this command: vncserver -geometry 1792x1008 -alwaysshared
3) Connect to the vncserver and try to ctrl+f or ctrl+t in chromium for example. Nothing happens.

Now downgrade fltk and restart the vncserver. The ctrl+x combinations work as expected.
Comment by Eric Belanger (Snowman) - Tuesday, 18 November 2014, 03:43 GMT
Please try with fltk-1.3.3-2 in [testing] repo.
Comment by Mauro Santos (R00KIE) - Tuesday, 18 November 2014, 13:06 GMT
At least here fltk-1.3.3-2 does not seem to solve the ctrl+other_key problem. Regarding the segfault, I have not experienced it (system is updated at least daily).
Comment by Robot Anarchy (robotanarchy) - Tuesday, 18 November 2014, 16:30 GMT
Snowman: I've just tried out fltk-1.3.3-2 in testing and it still segfaults at the same point!

I've reported this even more upstream, in the fltk bugtracker:

http://www.fltk.org/str.php?L3152+P0+S-2+C0+I0+E0+Q

A patch posted by AlbrechtS there seems to fix the issue, as another user has reported. How about shipping that patch in arch, until the next fltk version is released, that ships it anyway?

PS: @graysky: I'm also affected by the CTRL-issue, but this should really be in another bug report. We talk about a segfault on connection in this one! Also you seem to have posted the wrong link.
Comment by Eric Belanger (Snowman) - Wednesday, 19 November 2014, 00:59 GMT
I applied that patch in fltk-1.3.3-3

For the CTRL+ issue, you might want to ask upstream about it.
Comment by Nicola (drakkan) - Wednesday, 19 November 2014, 11:23 GMT
with fltk-1.3.3-3 no more segfaults in tigervnc for me
Comment by Robot Anarchy (robotanarchy) - Wednesday, 19 November 2014, 17:40 GMT
The segfault is fixed in 1.3.3-3, thanks a lot!
Comment by John (graysky) - Thursday, 20 November 2014, 00:47 GMT
@Robot A - I opened  FS#42796  as you see but snowman closed it pointing to this one. I requested that it gets reopened.
I can confirm that 1.3.3-3 does not fix the ctrl+x bug.
Comment by John (graysky) - Thursday, 20 November 2014, 00:54 GMT
For the control key issue: http://www.fltk.org/str.php?L3155+P0+S-2+C0+I0+E0+Q
Comment by Thomas Martin Klein (nikin) - Sunday, 14 December 2014, 19:46 GMT
tigervnc 1.4 is out. I flagged the package to be updated.
This should help with this issue. As:
https://github.com/TigerVNC/tigervnc/issues/72
Maybe try to work without the patch after that?
Comment by U (Gusar) - Sunday, 14 December 2014, 22:15 GMT
This issue was fixed already in fltk-1.3.3-3 and the update to tigervnc-1.3.90 (1.4 beta) that's currently in Arch. A patch for fltk is still required, however not the entire patch as used in fltk-1.3.3-3, just the part mentioned in http://www.fltk.org/str.php?L3152 - basically just the last hunk of the current tigervnc.patch

Switching to tigervnc-1.4 will be "fun", as the recent security fixes in Xorg break tigervnc compilation. There's a temporary hacky fix in the tigervnc-devel mailing list, I'll test if it works, then open a bug report against tigervnc with the fix and new pkgbuild. In any case, this bug can be closed, the crasher is fixed.

Loading...