FS#42736 - Pacman crashes when trying to download .sig files when XferCommand is used

Attached to Project: Pacman
Opened by David Macek (Elieux) - Monday, 10 November 2014, 21:56 GMT
Last edited by Allan McRae (Allan) - Wednesday, 19 November 2014, 06:16 GMT
Task Type Bug Report
Category Backend/Core
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity High
Priority Normal
Reported Version git
Due in Version 4.2.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

Commit: 9d96bed9d6b57c1f3cfb4220e80f6dd473d86683 * be_sync: use effective URL for db file signature download
Mailing list: https://lists.archlinux.org/pipermail/pacman-dev/2014-October/019430.html

This change caused pacman to crash when trying to download .sig file when external download command is used (XferCommand).
A limited stacktrace at the time of the crash can be seen here: https://gist.github.com/elieux/91f5f473d2faa52f5bd4
In alpm_db_update (be_sync.c), _alpm_download is expected to have set final_db_url on its return, but as can be seen in the function (dload.c) in the else branch, final_url is left untouched. The crash happens around line 246, in what is effectively a strlen(NULL).

Tested on MSYS2, see https://github.com/Alexpux/MSYS2-packages/tree/master/pacman.

Steps to Reproduce:
1) set XferCommand
2) run pacman -Sy
This task depends upon

Closed by  Allan McRae (Allan)
Wednesday, 19 November 2014, 06:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  git commit 8c00dd7341
Comment by Allan McRae (Allan) - Monday, 17 November 2014, 07:17 GMT
Patch attached.
   0001-Fix-crash-when-using-ext... (1.9 KiB)

Loading...