FS#42726 - [devtools] makechrootpkg doesn't update pkgver in PKGBUILD like makepkg for vcs source

Attached to Project: Arch Linux
Opened by James Duley (parched) - Sunday, 09 November 2014, 21:25 GMT
Last edited by Eli Schwartz (eschwartz) - Monday, 31 July 2017, 22:14 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: For example, I was building a bzr package with extra-x86_64-build which builds the package fine pulling new source etc.
However, it doesn't update the pkgver in the PKGBUILD like makepkg would.

This may be intentional, in which case this is a feature request not a bug report.


Steps to reproduce:
extra-x86_64-build in a directory with a bzr PKGBUILD, I assume this is the case with other VCS sources too.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Monday, 31 July 2017, 22:14 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in commit ca819a23579114f57476a609314efbe7d1bf2aea and available since v20160528
Comment by Dave Reisner (falconindy) - Monday, 10 November 2014, 15:53 GMT
To be clear, the PKGBUILD in the build directory (where makepkg actually ran) *will* be updated. We don't copy that PKGBUILD back to the directory where you invoked makechrootpkg from.
Comment by James Duley (parched) - Monday, 10 November 2014, 22:22 GMT
Ok, that makes sense. Do you want to make it copy it back too or leave it as is?
Comment by Dave Reisner (falconindy) - Monday, 10 November 2014, 22:29 GMT
I think I want to take the conservative approach here. Perhaps we can detect the change and produce a diff? I'm not sure I want to clobber the PKGBUILD wholesale (I worry about bugs resulting in empty/corrupted PKGBUILDs).
Comment by James Duley (parched) - Monday, 10 November 2014, 22:34 GMT
Fair enough, I think you can probably just reuse most of the update_pkgver function from makepkg which just uses sed to update it by the looks.
Comment by NicoHood (NicoHood) - Saturday, 07 January 2017, 13:20 GMT
This issue seems to be invlaid/solved by now as explained in this comment:
https://bugs.archlinux.org/task/44827#comment154149

Loading...