FS#42474 - [libraw] pkg-config files are wrong

Attached to Project: Arch Linux
Opened by Jérémy (jeyzu) - Tuesday, 21 October 2014, 09:05 GMT
Last edited by Andrea Scarpino (BaSh) - Friday, 24 October 2014, 07:16 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Andrea Scarpino (BaSh)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description: pkg-config files are wrong

Additional info:
* package version: 0.16.0-2 x86_64


Steps to reproduce:
$ pkg-config --cflags libraw
-I/usr/include/libraw/libraw

should be: -I/usr/include/libraw
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Friday, 24 October 2014, 07:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  libraw 0.16.0-3
Comment by Doug Newgard (Scimmia) - Tuesday, 21 October 2014, 12:49 GMT
This file comes from upstream, Arch doesn't do anything to it in packaging. Please report this to them.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 10:45 GMT
My bad for opening a duplicate. Thank you Doug for closing that one.

More information about the issue from my duplicate report:
It was a bug in the cmake version of libraw, which arch has switched to as of version 0.16.0-2. It's already fixed in upstream, just not included in 0.16.0, and they don't have 0.16.1 just yet. I opened a ticket in upstream (https://github.com/LibRaw/LibRaw/issues/41) asking them to release 0.16.1. Until then it's probably best if arch either moves back to autotools (like 0.16.0-1), or just patches libraw locally.

Additional info:
* package version: 0.16.0-2 is the only one affected.

Steps to reproduce:
run "pkg-config --cflags libraw" and see that the include path is broken (double libraw).
Comment by Andrea Scarpino (BaSh) - Thursday, 23 October 2014, 10:51 GMT
I don't get why the hell they use 2 build system if cmake is always broken. (I just had the same issue with libvncserver).

I'll switch to autotools.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 10:53 GMT
Yeah, it's a bit odd. As mentioned, I already urged upstream to release a version with the fix, so let's hope this will be completely solved soon anyway.

In the meanwhile, switching back to autotools seems like the way to go.

Thanks.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 10:55 GMT
I was just told by Doug that the reason for switching to the cmake build was that the autotools build doesn't install the .cmake files. So maybe just use the upstream patch locally to the package until they release a version with it in upstream?

Edit: more info by doug: https://bugs.archlinux.org/task/42448
Comment by Andrea Scarpino (BaSh) - Thursday, 23 October 2014, 11:01 GMT
Nice catch Doug. I forgot about that one.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 11:05 GMT
See my report to upstream, it includes the relevant commit hash that fixed it back in 2013... :)
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 12:54 GMT
Upstream is resisting the fixes.
They rejected my patch for fixing the autotools build:
https://github.com/LibRaw/LibRaw/pull/42

And are saying it's not a bug in my ticket:
https://github.com/LibRaw/LibRaw/issues/41

While arguing that cmake is not supported.

Honestly, I don't know what's next.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 13:06 GMT
OK. Cmake is now removed from master completely, so it's surely a good idea to revert to autotools (0.16.0-1), and maybe just include my pull request 42 as an interim fix until I manage to get him to add it to master.
Comment by Andrea Scarpino (BaSh) - Thursday, 23 October 2014, 13:10 GMT
If they don't ship the cmake files we cannot neither. Who want to use libraw using cmake will have to copy those files into their cmake/module project dir.

Thanks anyway.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 13:11 GMT
I figured you'd say that, as this is the right thing to do. :(

OK. I guess you'll have to revert to 0.16.0-1 and reopen the other bug. We'll have to wait and hope libraw upstream does the right thing.
Comment by Tom (tomarchbug) - Thursday, 23 October 2014, 13:22 GMT
I gave up on upstream.

Loading...