FS#42258 - [gufw] Reduce dependencies

Attached to Project: Community Packages
Opened by Balló György (City-busz) - Sunday, 05 October 2014, 14:37 GMT
Last edited by Balló György (City-busz) - Sunday, 19 October 2014, 20:38 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Martin Wimpress (flexiondotorg)
Architecture All
Severity Very Low
Priority Low
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

- I think that gnome-icon-theme-symbolic is not needed, gufw should work fine with any icon theme.

-lxpolkit, mate-polkit, polkit-gnome: I recommend to remove these from optdepends, because it depends on the actually used desktop environment if the user needs one or not.
This task depends upon

Closed by  Balló György (City-busz)
Sunday, 19 October 2014, 20:38 GMT
Reason for closing:  Fixed
Comment by Martin Wimpress (flexiondotorg) - Monday, 06 October 2014, 11:06 GMT
`gnome-icon-theme-symbolic` is required - http://bazaar.launchpad.net/~costales/gui-ufw/gufw-14.10/view/head:/INSTALL

I have removed the optdepends for `lxpolkit`, `mate-polkit`, `polkit-gnome` in gufw-14.10.1 which is also a new upstream release.
Comment by Balló György (City-busz) - Monday, 06 October 2014, 13:24 GMT
Even if upstream states that it depends on gnome-icon-theme-symbolic, it just requires an icon theme which contains the following icons:
- edit-find-symbolic
- list-add-symbolic
- list-remove-symbolic
- emblem-system-symbolic

These icons can be found also in mate-icon-theme, and in the new awaita-icon-theme, which is the default icon them since GTK+ 3.14 (currently in [testing]).

So there is no hard dependency on gnome-icon-theme-symbolic.
Comment by Costales (costales) - Monday, 06 October 2014, 17:16 GMT
Hi! I'm a Gufw developer.
This dependence was added by this bug: https://bugs.launchpad.net/ubuntu/+source/gui-ufw/+bug/878639 because in some environments the icons are from that package: https://launchpadlibrarian.net/83232891/gufw-missing%20icons.png
Best regards!
Costales
Comment by Balló György (City-busz) - Monday, 06 October 2014, 17:30 GMT
Thanks you for the explanation. But I think it's not in case with GTK+ 3.14, which uses Adwaita icon theme by default, and depends on it, so the symbolic icons will be available on all systems.
Comment by Martin Wimpress (flexiondotorg) - Tuesday, 07 October 2014, 18:13 GMT
I am following upstream advice and they have even explained why the dependency was added. With no mechanism within PKGBUILD to stipulate 'icons_a or icons_b' without updating all the icon themes with 'provides=('gufw-symbolic-icons') I am not sure what I am supposed to do with this ticket?
Comment by Balló György (City-busz) - Sunday, 19 October 2014, 20:37 GMT
Since GTK+ 3.14 is already in [extra], I removed gnome-icon-theme-symbolic dependency in trunk.

Loading...