FS#41864 - [dzen2] PKGBUILD breaks version number (also add docs, CFLAGS)

Attached to Project: Community Packages
Opened by Steven Honeyman (stevenhoneyman) - Sunday, 07 September 2014, 21:51 GMT
Last edited by Sergej Pupykin (sergej) - Friday, 12 September 2014, 12:07 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Due to using double quotes instead of single in the PKGBUILD, the version number is truncated (shown in `dzen2 -v`)

Currently: CFLAGS=" -Wall -Os ${INCS} -DVERSION=\"${VERSION}\" -DDZEN_XINERAMA -DDZEN_XPM -DDZEN_XFT `pkg-config --cflags xft`"
Fixed: CFLAGS=' -Wall -Os ${INCS} -DVERSION=\"${VERSION}\" -DDZEN_XINERAMA -DDZEN_XPM -DDZEN_XFT `pkg-config --cflags xft`'
(or...) CFLAGS=" -Wall -Os \${INCS} -DVERSION=\\\"\${VERSION}\\\" -DDZEN_XINERAMA -DDZEN_XPM -DDZEN_XFT `pkg-config --cflags xft`"

Additional info:

* It would be nice to have documentation (either the READMEs that come with it, or steal debian's manpages)
* The makefiles do not include environment(makepkg) cflags or ldflags, resulting in potentially exploitable binaries, as no hardening is done
* There's an upstream typo that stops XPM from showing as supported ( s/XMP/XPM/ )

Finally:

* There are patches for all the above that I've just commited and sent a pull request to upstream for, if you want to include/use:
https://github.com/robm/dzen/pull/25
This task depends upon

Closed by  Sergej Pupykin (sergej)
Friday, 12 September 2014, 12:07 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.9.5git-4
Comment by Steven Honeyman (stevenhoneyman) - Friday, 12 September 2014, 10:42 GMT
  • Field changed: Percent Complete (100% → 0%)
What about the other stuff? I'll raise 4 seperate tickets if you want, but as theyre such minor changes I figured this would cut down on email traffic etc.

Loading...