FS#41471 - [xdg-user-dirs] add a sh extension to the xinitrc.d script

Attached to Project: Arch Linux
Opened by Daniel Micay (thestinger) - Tuesday, 05 August 2014, 00:10 GMT
Last edited by Andreas Radke (AndyRTR) - Monday, 09 November 2015, 13:28 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Andreas Radke (AndyRTR)
Jan Alexander Steffens (heftig)
Tom Gundersen (tomegun)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

The upstream /etc/X11/xinit/xinitrc only sources files with the sh extension so this is skipped.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Monday, 09 November 2015, 13:28 GMT
Reason for closing:  Fixed
Additional comments about closing:  Initial bug is fixed by the xdg-user-dirs 0.15-2 update.
Comment by Jan Alexander Steffens (heftig) - Saturday, 27 September 2014, 20:26 GMT
Yet, all our xinitrc.d files (in dbus, libcanberra and xdg-user-dirs) have no .sh extension. Maybe we need to fix the xinitrc script.

On the other hand, all these files come from us, not upstream. I'll add the maintainers of the other packages and maybe we'll come to a solution. I guess we'll add the .sh extension everywhere.
Comment by Jan Alexander Steffens (heftig) - Saturday, 27 September 2014, 20:33 GMT
I'm a bit confused about the xinit setup we ship. Does ~/.xinitrc (whose skel version does read files without .sh) completely override /etc/X11/xinit/xinitrc?
Comment by Daniel Micay (thestinger) - Saturday, 27 September 2014, 23:51 GMT
Our skel .xinitrc overrides the global xinitrc but of course that's opt-in for users created before installing xinit. It's an Arch-specific file though so it's written to work with the xinitrc.d scripts shipped by packages.

The global one has the default tmux / xclock / xterm environment and the wiki encourages using it for testing. Since it requires `*.sh` and comes from upstream, adding the suffix seems like the right thing to do. I noticed that this was one was users on the forums ended up without dbus being started.
Comment by Doug Newgard (Scimmia) - Thursday, 26 March 2015, 16:24 GMT
And now that there is no .xinitrc in /etc/skel, this file will never get source unless the user changes this manually.
Comment by Jan Alexander Steffens (heftig) - Thursday, 26 March 2015, 16:25 GMT
At least /etc/gdm/Xsession still does, though.
Comment by Doug Newgard (Scimmia) - Thursday, 26 March 2015, 16:32 GMT
TBH, this should probably be changed upstream since it doesn't work with the default xorg configuration. I'll file a bug report.

Edit: Oh wait, this file comes from Arch. Nevermind.
Comment by Daniel Micay (thestinger) - Thursday, 26 March 2015, 20:19 GMT
The default /etc/X11/xinit/xinitrc sources it, but only if it has a sh extension. The wiki could be updated to get people to start with that file by copying it to their home directory. It's too bad that whatever generates it fills it with unnecessary whitespace though...

Loading...