FS#41428 - [oolite] Libpng library errors

Attached to Project: Community Packages
Opened by RG (weedfreak) - Friday, 01 August 2014, 14:43 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 28 August 2014, 05:31 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The stadard game works OK but attempting to add any expansions through the in game Addon Manager or manually will produce errors.

Additional info:
* package version(s)1.80
The Oolite installer includes libpng1.4 as a hardwired library, the PKGBUILD uses the current version 1.6 which is less forgiving.
See http://aegidian.org/bb/viewtopic.php?f=9&t=14832&p=224536#p224536 for a discussion of the problem and a possible workaround for manual addons.


Steps to reproduce:
Checking the logfiles after running the vanilla game may show just one error in a png in the game resources.
Install addons by manually adding oxp folders available from the game site, after loading a game or possibly playing for a short while, dependant on which addons and where you are, checking the log should show lots of errors. The script in the thread above can clear these.
If you install addons via the in game manager they are stored as compressed files and the script will not correct the errors, the log will show the errors and most addons will not work correctly.

The install needs to require libpng1.4 to prevent the errors in all cases.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Thursday, 28 August 2014, 05:31 GMT
Reason for closing:  Upstream
Comment by Doug Newgard (Scimmia) - Friday, 01 August 2014, 15:04 GMT
Sounds more like they need to fix their pngs.
Comment by RG (weedfreak) - Friday, 01 August 2014, 15:14 GMT
Agreed, but as some of the content is over 10 years old and the original creator has moved on and the problem seems only to affect Arch Linux users perhaps linking the thing to an old library might solve the problem while they work on a more permanent solution from their end.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 07 August 2014, 13:12 GMT
Why would it be a problem to merely batch convert all the pngs as you suggested? I suppose you have some kind of central repository with all the addons in it. Why isn't it quite trivial to convert it? It wasn't exactly clear from the discussion you linked. It doesn't even matter how old the content is.

I don't really see how we can fix this on our side as apparently the pngs are only downloaded at runtime, not at make time. If it were a make time issue, I could just run convert on it and fix the format that way.

By the way, the people in that thread seem to be grossly misinformed about how pacman works. It does not compile stuff for you, it downloads signed package from our binary repos and installs that.
Comment by RG (weedfreak) - Thursday, 07 August 2014, 16:33 GMT
Batch conversion of files is the method I use locally. The various png files are distributed over some 400 different users sites, mostly these are user contributions, some are no longer maintained, and various combinations can be added at run time. To allow this to happen the programme is mostly distributed as a binary with a static link to libpng1.4, this binary does not work with a couple of disto's. A suggestion was to load 1.4 and 1.6 on Arch and link Oolite to the 1.4 library, which I think would need to be in the package.
There was a plan to force the png's into a compressed package format that would make correcting them harder and linking the package to 1.4 a better solution, it seems this plan may have changed, so local script correction may now be the best option for Arch users
Outside Arch I think there is a great deal of misunderstanding, sometimes within the Arch community as well.
Comment by Lone_Wolf (Lone_Wolf) - Sunday, 17 August 2014, 23:18 GMT
The consensus on Oolite BBS now appears to be that the best solution is to report the errors and have them fixed.

2 expansions have already been fixed.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 28 August 2014, 05:31 GMT
I will close this bug as it appears I really can't do anything from the position of the package. Reopen if I'm in error.

Loading...