FS#41328 - [sqlitebrowser] Switch from qmake-qt5 to cmake

Attached to Project: Community Packages
Opened by Muflone (muflone) - Thursday, 24 July 2014, 16:08 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 28 July 2014, 09:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The package sqlitebrowser uses qmake-qt5 to build from source in contrast to the author's building instructions, see BUILDING.md file provided from the upstream source (https://github.com/sqlitebrowser/sqlitebrowser/blob/sqlb-3.2.0/BUILDING.md) resulting in a skipped CMakeLists.txt file.

The upstream author has moved to qmake to cmake
https://github.com/sqlitebrowser/sqlitebrowser/issues/29#issuecomment-44314921

The first symptom of skipping the use of CMakeLists.txt is the wrong version number in the application about dialog.

The git version of sqlitebrowser already had a lot of fixes in CMakeLists.txt but no fixes (translations building and others) in the sqlitebrowser.pro file.

I'm unsure if any other defects could happen if you use the outdated sqlitebrowser.pro file.

Additional info:
* sqlitebrowser 3.2.0-1

Steps to reproduce:

Open the Help menu and select About.
The version shown is master_git instead of 3.2.0.

Building the package with:
$ cmake -DCMAKE_BUILD_TYPE=Release -DUSE_QT5=True .
$ make
the same dialog will show the correct version number 3.2.0.
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 28 July 2014, 09:35 GMT
Reason for closing:  Fixed

Loading...