FS#41221 - [pacdiff] Add vim as opt-depend

Attached to Project: Pacman
Opened by Daniel (weirddan455) - Wednesday, 16 July 2014, 16:57 GMT
Last edited by Allan McRae (Allan) - Wednesday, 16 July 2014, 22:19 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 4.1.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If vim is not installed, the default configuration of pacdiff leaves the user unable to view a .pacnew file. Example output:

==> pacnew file found for /etc/pacman.d/mirrorlist
:: (V)iew, (S)kip, (R)emove pacnew, (O)verwrite with pacnew: [v/s/r/o] v
/usr/bin/pacdiff: line 144: vimdiff: command not found
rm: remove regular file ‘/etc/pacman.d/mirrorlist.pacnew’? n

Installing vim provides the vimdiff command and allows pacdiff to function as expected. It seems this fits the bill for a typical opt-depend since pacdiff is non-essential to the functioning of pacman itself but lacking the vim package will nevertheless leave pacdiff broken in its default configuration.
This task depends upon

Closed by  Allan McRae (Allan)
Wednesday, 16 July 2014, 22:19 GMT
Reason for closing:  Won't implement
Comment by Karol Błażewicz (karol) - Wednesday, 16 July 2014, 22:01 GMT
https://bugs.archlinux.org/task/34745
Comment by Allan McRae (Allan) - Wednesday, 16 July 2014, 22:19 GMT
pacdiff provides a helpful message if vim is not installed (at least in pacman-git). So I will not be adding an optdepend.

Loading...