FS#41094 - [xorg-twm] installing and backing up wrong defaults file in wrong location

Attached to Project: Arch Linux
Opened by Brian BIdulock (bidulock) - Friday, 04 July 2014, 23:52 GMT
Last edited by Laurent Carlier (lordheavy) - Monday, 04 August 2014, 07:53 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Andreas Radke (AndyRTR)
Laurent Carlier (lordheavy)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

xorg-twm 1.0.8-1 is installing the wrong defaults file in the wrong location.

The upstream package is installing its default file in /usr/share/X11/twm/system.twmrc
during 'make install' and this is the file referenced by the program:

$> strings /usr/bin/twm | grep share
/usr/share/X11/twm/system.twmrc

The PKGBUILD is installing the same file in /etc/X11/twm/system.twmrc and placing it in the backup array. This file is not referenced by the program:

strings /usr/bin/twm | grep etc
XFetchBytes

Fix:

replace etc/X11/twm/system.twmrc in backup=() with usr/share/X11/twm/system.twmrc
remove lines from PKGBUILD that install etc/X11/twm/system.twmrc

Additional info:
* package version(s)
xorg-twm 1.0.8-1

* config and/or log files etc.


Steps to reproduce:
remove or move away any ~/.twmrc file you have
launch twm e.g. $> startx /usr/bin/twm
select Xterm from the root menu
sudoedit the file /etc/X11/twm/system.twmrc
-> remove the "Xterm" entry in the "defops" menu
select Exit from the root menu
relaunch twm
observe Xterm entry still in root menu

repeat but edit /usr/share/X11/twm/system.twmrc instead
observe Xterm entry removed from root menu

move your ~/.twmrc file back if you have one

This task depends upon

Closed by  Laurent Carlier (lordheavy)
Monday, 04 August 2014, 07:53 GMT
Reason for closing:  Fixed
Additional comments about closing:  xorg-twm-1.0.8-3
Comment by Brian BIdulock (bidulock) - Sunday, 03 August 2014, 18:46 GMT
  • Field changed: Percent Complete (100% → 0%)
Still broken in 1.0.8-2. All that 1.0.8-2 did was remove the file that /usr/bin/twm uses as the default.
Comment by Laurent Carlier (lordheavy) - Sunday, 03 August 2014, 23:05 GMT
The proper file to configure twm is in the home directory of the user (~/.twmrc), see man twm
systemrc.twmrc must not be modified, its proper place is in /usr/share/X11/twm/

I will patch the manpage to reflect the right emplacement for systemrc.twmrc file
Comment by Brian BIdulock (bidulock) - Sunday, 03 August 2014, 23:55 GMT
man twm: system.twmrc: "This is often tailored by the site administrator to provide convenient menus or familiar bindings for novice users." Please put usr/share/X11/twm/system.twmrc in backups.

See https://aur.archlinux.org/packages/xorg-twm-git/ for a proper installation.
Comment by Laurent Carlier (lordheavy) - Monday, 04 August 2014, 07:46 GMT
You're right, from the manpage system administrator can modify system.twmrc, and will be in the backups array.

I can't refer to a package which is wrong.

Loading...