Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#41032 - [monit] Use upstream systemd service file

Attached to Project: Community Packages
Opened by Guillaume ALAUX (galaux) - Sunday, 29 June 2014, 12:48 GMT
Last edited by Jaroslav Lichtblau (Dragonlord) - Friday, 24 October 2014, 20:45 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Upstream provides its own systemd 'service' file that this package could use instead of providing its own.

Additional info:
* package version(s)
* config and/or log files etc.


Steps to reproduce:
This task depends upon

Closed by  Jaroslav Lichtblau (Dragonlord)
Friday, 24 October 2014, 20:45 GMT
Reason for closing:  Fixed
Comment by Jaroslav Lichtblau (Dragonlord) - Thursday, 16 October 2014, 13:02 GMT
There seems to be no compile option to automatically include the .service file.
I've updated the current file with the values from the original one in monit-5.9-1
I'm open to any better suggestions here.
Comment by Guillaume ALAUX (galaux) - Thursday, 16 October 2014, 19:52 GMT
I was not specifically looking for a way to automatically include it during the make step rather than just using the file provided by upstream instead of duplicating it :)

That's what I had in mind http://pastebin.com/QZBW7Wnf

Just in case upstream updates its service file, you will automatically ship it.

Feel free to close this bug report whether you follow my idea or not :)
Comment by Jaroslav Lichtblau (Dragonlord) - Friday, 24 October 2014, 18:46 GMT
I don't believe the "${prefix}" part from the [Service] section of the shipped .service file is fine to have in our package.
I'll keep this in mind and look in the future releases of monit for better way to use the upstream file, but will keep it as is for now.
Comment by Guillaume ALAUX (galaux) - Friday, 24 October 2014, 20:05 GMT
I think you got me wrong, there is no "${prefix}" anymore once you use "--sysconfdir=/etc". It turns the monit.service.in into… well exactly what you ship "by hand" (comments excpeted).
Comment by Jaroslav Lichtblau (Dragonlord) - Friday, 24 October 2014, 20:27 GMT
I did miss the --sysconfdir option. Now it makes sense and is in monit 5.9-2.

Loading...