FS#40936 - [vte3] executable flag missing on /etc/profile.d/vte.sh

Attached to Project: Arch Linux
Opened by Steven Honeyman (stevenhoneyman) - Sunday, 22 June 2014, 18:41 GMT
Last edited by Jan Alexander Steffens (heftig) - Sunday, 22 June 2014, 23:24 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

This file is an executable script called from /etc/profile
As such, it should be marked as executable, currently it's just -rw-r--r--

Steps to reproduce:

$ ls /etc/profile.d/*.sh
-rwxr-xr-x 1 root root 102 Oct 24 2013 /etc/profile.d/gpm.sh*
-rwxr-xr-x 1 root root 152 Mar 28 14:29 /etc/profile.d/jre.sh*
-rwxr-xr-x 1 root root 156 May 8 15:35 /etc/profile.d/libreoffice-common.sh*
-rwxr-xr-x 1 root root 1.1K Jun 4 15:39 /etc/profile.d/locale.sh*
-rwxr-xr-x 1 root root 50 Sep 10 2011 /etc/profile.d/mozilla-common.sh*
-rwxr-xr-x 1 root root 668 Jun 19 20:08 /etc/profile.d/perlbin.sh*
-rw-r--r-- 1 root root 1.9K May 24 00:29 /etc/profile.d/vte.sh
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Sunday, 22 June 2014, 23:24 GMT
Reason for closing:  Not a bug
Comment by Doug Newgard (Scimmia) - Sunday, 22 June 2014, 23:15 GMT
That's now upstream installs it, and since it's sourced, it really doesn't matter. If you want it fixed, I would talk to them.
Comment by Jan Alexander Steffens (heftig) - Sunday, 22 June 2014, 23:24 GMT
No, executability would be wrong. I'd rather make a case for *removing* executability from all scripts in /etc/profile.d.

1) There's no shebang, so the kernel will throw ENOEXEC at you. Now, the shell will catch that and try to interpret the files, but...
2) There's no point in executing them like programs. They contain statements meant to affect the current shell.

The only point of executability would be to have it as a marker that /etc/profile tests for before sourcing. It would give you the ability to selectively exclude scripts from the profile. However, we don't actually do that at the moment, and pacman would override the flag on update anyway.

Loading...