FS#40924 - Need glances updated to latest git for Docker compatibility

Attached to Project: Community Packages
Opened by Scott (firecat53) - Saturday, 21 June 2014, 15:27 GMT
Last edited by Sébastien Luttringer (seblu) - Sunday, 22 June 2014, 19:20 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Starting with glances 2.0, it fails to start when a numeric process user exists, such as those sometimes occurring with running Docker containers. See bug report here: https://github.com/nicolargo/glances/issues/380

Fixed in latest git version (see bug report for exact commit)

Steps to reproduce: See bug report.
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Sunday, 22 June 2014, 19:20 GMT
Reason for closing:  Won't fix
Additional comments about closing:  2.0.1 embed the fix.
Comment by Dave Reisner (falconindy) - Saturday, 21 June 2014, 15:39 GMT
Could you explain why it wouldn't be sufficient to just cherrypick this fix?
Comment by Scott (firecat53) - Saturday, 21 June 2014, 16:05 GMT
If the user base that this affects is small enough, I have no problem taking care of it for myself. Just thought I'd put it in the system since Docker usage seems to be climbing overall, and it's hard to say when the glances author will release another point release including that commit that would make into our repos.

Thanks,
Scott
Comment by Dave Reisner (falconindy) - Saturday, 21 June 2014, 16:07 GMT
That doesn't answer my question. There's a huge difference between following the git repo (unstable), and backporting that *one* commit to the package in [community]. Are there merge conflicts (or missing functional dependencies) with applying that patch to 2.0?
Comment by Scott (firecat53) - Saturday, 21 June 2014, 17:56 GMT
Sorry, I misunderstood your comment. I see now the concern. It's a one-line patch, so I don't see why it couldn't be cherrypicked. TBH, I haven't tried that yet, but I can if you'd like.

@@ -141,7 +141,8 @@ def msg_curse(self, args=None):
msg = '{0:>6}'.format(p['pid'])
ret.append(self.curse_add_line(msg))
# USER
- msg = ' {0:9}'.format(p['username'][:9])
+ # docker internal users are displayed as ints only, therefore str()
+ msg = ' {0:9}'.format(str(p['username'])[:9])
ret.append(self.curse_add_line(msg))
# NICE
nice = p['nice']

Scott
Comment by Sébastien Luttringer (seblu) - Sunday, 22 June 2014, 19:19 GMT
Upstream release frequently, we will not follow development branch.

Moreover, 2.0.1 ship the commit fixing the issue.

Loading...