FS#40821 - [wpa_supplicant] Add ordering of systemd units after network-pre.target

Attached to Project: Arch Linux
Opened by Leonid Isaev (lisaev) - Thursday, 12 June 2014, 17:53 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Sunday, 20 November 2016, 19:56 GMT
Task Type Feature Request
Category Packages: Core
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Systemd-214 in [testing] introduced a new network-pre.target which is a passive unit designed to be started before any netrok-related services: http://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ .

Can we modify wpa_supplicant-related services to be "After=network-pre.target"? This change is supposed to have zero cost on a default install, but is useful for people who actually make use of this target.

Since there is an upstream update pending anyway and systemd-214 will spend some time in [testing], the above change can also be put in [testing] and moved to [core] together with, or after systemd...

Thanks.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Sunday, 20 November 2016, 19:56 GMT
Reason for closing:  Upstream
Comment by Dave Reisner (falconindy) - Thursday, 12 June 2014, 18:47 GMT
Ordering on network-pre is supposed to be for firewall-like services which need to run before the network is fully configured. I'm not convinced you want to order this earlier than network.target.
Comment by Leonid Isaev (lisaev) - Thursday, 12 June 2014, 20:05 GMT
Ordering after network-pre.target does _not_ imply before network.target, or am I misreading your post?

My simplistic view is (after asking all those questions on systemd-devel): before network-pre.target (if it is activated), all real interfaces are down and no virtual interfaces exist. All the configuration happens (or requested) in between network-pre and network targets.

wpa_supplicant is currently beyond this logic (it only cares about the presence of devices). Yet, it does configure the relevant interfaces (brings them up, associates, etc.). I understand that we _don't_ want to demand wpa_supplicant to be started before network.target is reached; but this request is about the "lowest ordering point" (network-pre.target), while network.target provides the "highest one".

I also don't have a bigger picture of which other daemons may need similar "fixes"...
Comment by Yamakaky (Yamakaky) - Wednesday, 10 September 2014, 20:14 GMT
Leonid is right, see http://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ : "Network management services hence should set After=network-pre.target, but avoid any Wants=network-pre.target or even Requires=network-pre.target."
Comment by Bartłomiej Piotrowski (Barthalion) - Sunday, 20 November 2016, 19:56 GMT
We don't ship custom systemd units in the package, everything is shipped by upstream. Please report it there.

Loading...