FS#40476 - [redshift] /usr/lib/systemd/user/redshift-gtk.service contains wrong binary name in ExecStart

Attached to Project: Community Packages
Opened by Bastien Traverse (Neitsab) - Wednesday, 21 May 2014, 00:49 GMT
Last edited by Lukas Fleischer (lfleischer) - Friday, 09 January 2015, 13:36 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Strangely enough the systemd user service file shipped by Arch for redshift-gtk differs from the one upstream and contains the wrong binary name. Instead of "redshift-gtk" it contains "redshift".

As a consequence the tray icon doesn't appear when starting the service (note: starting the service requires to add the option "Environment=DISPLAY=:0" to the service file's [Service] section. This is an upstream bug to be soon reported, see https://bbs.archlinux.org/viewtopic.php?pid=1417568#p1417568).

Additional info:
* package versions: redshift 1.9-3, 1.9.1-1
* original and working /usr/lib/systemd/user/redshift-gtk.service files attached.


Steps to reproduce:
# pacman -S redshift
$ cat /usr/lib/systemd/user/redshift-gtk.service | grep ExecStart
ExecStart=/usr/bin/redshift
Check upstream file: https://github.com/jonls/redshift/blob/master/data/systemd/redshift-gtk.service.in
--> contains ExecStart=@bindir@/redshift-gtk
   redshift-gtk.service_original (0.2 KiB)
   redshift-gtk.service_working (0.2 KiB)
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Friday, 09 January 2015, 13:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.10-1.
Comment by Bastien Traverse (Neitsab) - Wednesday, 21 May 2014, 01:09 GMT
Maybe it has something to do with how the --with-systemduserunitdir build option behaves. Here's the upstream commit merging the systemd changes: https://github.com/jonls/redshift/commit/00bb68332dfda66c2e98708d8c5eae693016a877.
Comment by Doug Newgard (Scimmia) - Wednesday, 21 May 2014, 01:21 GMT
This is also a bug upstream, so when you report the other one, do this, too. Try it yourself, when make generates the service from the .in, the binary name changes. Not sure if it's copying redshift.service.in or what.

Edit: confirmed, it's using redshift.service.in to create redshift-gtk.service
Comment by Bastien Traverse (Neitsab) - Wednesday, 21 May 2014, 02:00 GMT
I couldn't find this bug on redshift' Github, are you talking about "make" upstream?

Upstream bug report at https://github.com/jonls/redshift/issues/91, mentioning the possibility of a problem during the build phase.

Edit: good you found it, I don't have the sufficient knowledge to browse through the code and find that kind of issue.
Maybe you can point the incriminated lines in the upstream bug report?
Comment by Doug Newgard (Scimmia) - Wednesday, 21 May 2014, 02:04 GMT
I'm not saying that it has been reported upstream or anything. I'm saying that this isn't a packaging bug, but a bug in redshift's makefiles.

Edit, na, I haven't found where the bug is in their code, I just confirmed that redshift.service.in is being used by adding the filename to the top of each file.
Comment by Bastien Traverse (Neitsab) - Wednesday, 21 May 2014, 02:08 GMT
Okay, that clears it up, thanks. Bug's reported upstream, I think I did my maximum... We'll see.
Comment by Doug Newgard (Scimmia) - Sunday, 15 June 2014, 17:32 GMT
This has been fixed upstream, see the bug report Neitsab linked to.

Loading...