FS#40415 - Change default rsync entry in makepkg.conf's DLAGENTS
Attached to Project:
Pacman
Opened by Antony Lee (anntzer) - Sunday, 18 May 2014, 05:28 GMT
Last edited by Allan McRae (Allan) - Sunday, 29 June 2014, 09:55 GMT
Opened by Antony Lee (anntzer) - Sunday, 18 May 2014, 05:28 GMT
Last edited by Allan McRae (Allan) - Sunday, 29 June 2014, 09:55 GMT
|
Details
Currently, the default makepkg.conf contains the entry
'rsync::/usr/bin/rsync --no-motd -z %u %o'. I suggest adding
an '-a' flag, so that rsync can be used to download whole
directories (see discussion here:
https://bbs.archlinux.org/viewtopic.php?pid=1416342) -- after all, if the sources are already available as a
single file (tarball, etc.) then rsync is unlikely to be
necessary.
|
This task depends upon
Comment by Allan McRae (Allan) -
Sunday, 18 May 2014, 05:49 GMT
Adding -a means it will not be a drop in replacement for any other
of the DLAGENT examples. Also, that would require passing a
directory as the source, which is not understood by makepkg.
Comment by Antony Lee (anntzer) -
Sunday, 18 May 2014, 06:28 GMT
-a also works for single files, but the point is exactly to allow
passing a directory as source. Currently, this works fine (in the
case I tested:
http://pastebin.com/KVySC7Uk), except that 1/ makepkg does not avoid re-downloading the
sources when they are already there (because get_filepath uses [[
-f ]]) and 2/ checksums don't work on a whole directory; neither
of these issues seem crucial to me.
Comment by Allan McRae (Allan) -
Sunday, 18 May 2014, 06:48 GMT
If we add the -a, then we would have to fix everything else to
support directories properly. I have no interest in supporting
sources that are not a tarball or a VCS repo. In fact, I think
that package should be using individual files as source entries...
Comment by Antony Lee (anntzer) -
Sunday, 18 May 2014, 18:54 GMT
Should I understand that you'd not be interested in a patch that
would fix these two issues?
Comment by Allan McRae (Allan) -
Sunday, 29 June 2014, 09:54 GMT
We will not be supporting people that supply broken sources. Put
each file in the sources line in these cases.