Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#40311 - [patchage] does not work with jack2 as no metadata support

Attached to Project: Community Packages
Opened by Jelle Plantenberg (yellius) - Sunday, 11 May 2014, 19:10 GMT
Last edited by speps (archspeps) - Tuesday, 20 May 2014, 17:29 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ray Rashif (schivmeister)
speps (archspeps)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

--- [edited by assignee] ---
Does not start with the following output:

patchage: symbol lookup error: patchage: undefined symbol: JACK_METADATA_PRETTY_NAME

Works with jack from [extra].
--- [edited by assignee] ---

Please refer to this thread:
https://bbs.archlinux.org/viewtopic.php?pid=1413521
This task depends upon

Closed by  speps (archspeps)
Tuesday, 20 May 2014, 17:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  Jack metadata support has been disabled by default (no pretty names support), while jack2 will not handle metadata too.
Fixed in release 1.0.0-2
Comment by Jelle Plantenberg (yellius) - Sunday, 11 May 2014, 19:14 GMT
just checked the reporting guidelines, guess this should actually be severity "High"
Comment by Doug Newgard (Scimmia) - Sunday, 11 May 2014, 20:36 GMT
I didn't change this to high severity because it probably works with jack, which is what the dependencies say and what it was built against. Probably going to have to pick one or the other now.
Comment by Ray Rashif (schivmeister) - Monday, 12 May 2014, 11:55 GMT
Thank you for reporting, this is indeed a problem and patchage should be edited to require jack1 strictly, or a solution should be sought. The latter scenario is unlikely to prove fruitful as the two are separate implementations, so we will update patchage as needed within a day or two.

Please also make it a good habit to describe the issue in the bug report itself -- don't just link to references (they can and should be cited at the end). See https://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines#Including_relevant_information

edit: How about a patchage-jack2? This could be split from within patchage.
Comment by Doug Newgard (Scimmia) - Monday, 12 May 2014, 18:27 GMT
If they're incompatible, jack2 should probably not 'provide' jack. Would make setting up the deps simpler.
Comment by Jelle Plantenberg (yellius) - Tuesday, 13 May 2014, 06:35 GMT
It seems there is a fix/workaround available for jack2, probably better to update that package as both jack1 and jack2 should be equivalent implementation for the same protocol. See this link: https://github.com/jackaudio/jack2/pull/62
A google search also shows there is discussion in the jack2 team on implementing the metadata api.
Comment by Ray Rashif (schivmeister) - Tuesday, 13 May 2014, 09:42 GMT
Doug, they are not supposed to be incompatible for the most part; users should be able to use jack2 in place of jack1. These incompatibilities are corner cases.

Jelle, thank you, we'll take a look. This looks like a stopgap solution, but we'll have to see if it works well as a backport.
Comment by speps (archspeps) - Tuesday, 13 May 2014, 13:26 GMT
The real issue here is that the actual patchage build system checks for metadata support automatically and there's no flag for disabling it manually.

@schivmester
I'm going to push an 1.0.0-2 release, including a simple fix for disabling metadata support (it would work with both jack and jack2), if you agree.
Comment by Ray Rashif (schivmeister) - Tuesday, 13 May 2014, 18:01 GMT
Wouldn't that also deprive jack1 users of the metadata support through patchage? If not, go ahead if the patch is not too intrusive to the patchage code.

http://drobilla.net/2014/04/09/pretty-names-in-patchage-via-jack-metadata/
Comment by speps (archspeps) - Monday, 19 May 2014, 18:19 GMT
@schivmeister
Yep, it would. I thought it wouldn't be a big deal living without pretty names, while jack2 does not support metadata.
The patch I was talking about, just disable metadata forcedly in build system.
Btw, if you think we should provide this feature, your solution is fine. We should split patchage into patchage-jack{1,2} (both provides patchage).

I'll wait for your opinion before proceeding. (sorry for the late)
Comment by Ray Rashif (schivmeister) - Tuesday, 20 May 2014, 12:21 GMT
Speps, you thought right - in that case I agree with you. I'd rather not have to deal with split packages if the intervention is a few lines of modification. I'm skipping a backport as it's a lot of code and room for error. So go ahead with the fix (it's sitting broken at the moment) and then close this, thanks.

Loading...