Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#40114 - [glibc] The PKGBUILD for glibc has unquoted variables

Attached to Project: Arch Linux
Opened by Matthias Rabault (Mathuin) - Sunday, 27 April 2014, 14:35 GMT
Last edited by Allan McRae (Allan) - Wednesday, 30 April 2014, 04:29 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The PKGBUILD for glibc uses the $srcdir, $pkgdir variables without quoting them, which can cause problems if these variables contain spaces. The affected PKGBUILD is the one I found in the svntogit/packages.git repo.

This isn't critical at all, but it would be nice to have a PKGBUILD that can be built even in a folder whose parents include a space.

I have generated a patch, which is attached to this "bug" report (In git format-patch format)

Thanks in advance for your replies and please forgive my English errors, It's not my mothertongue.
This task depends upon

Closed by  Allan McRae (Allan)
Wednesday, 30 April 2014, 04:29 GMT
Reason for closing:  Won't fix
Additional comments about closing:  I don't care
Comment by Matthias Rabault (Mathuin) - Sunday, 27 April 2014, 14:41 GMT
Oops, there's a typo in the commit message, I forgot the second u in unquoted ...
Comment by Doug Newgard (Scimmia) - Sunday, 27 April 2014, 15:02 GMT
Patch is bad, but report is valid.
Comment by Matthias Rabault (Mathuin) - Sunday, 27 April 2014, 15:13 GMT
I am sorry for the quality of my patch. Could you explain me what's wrong ? I genuinely have no idea.
Comment by Doug Newgard (Scimmia) - Sunday, 27 April 2014, 15:16 GMT
Just scanning through, I noticed:

- rm $pkgdir/usr/lib/lib{anl,BrokenLocale,nsl,resolv,rt,util}.a
+ rm "$pkgdir/usr/lib/lib{anl,BrokenLocale,nsl,resolv,rt,util}.a"

You can't do brace expansion inside of quotes, so this change will fail.
Comment by Matthias Rabault (Mathuin) - Sunday, 27 April 2014, 15:23 GMT
I didn't know that. Thank you !

Loading...